Changeset 28788 for trunk/tests/phpunit/tests/media.php

Timestamp:

06/20/2014 06:26:17 PM (10 years ago)

Author:

wonderboymusic

Message:

Reinstate the changes from [28579] with some adjustments:

• Check ! empty( $postarr['file'] ) before calling update_attached_file()
• Add a unit test: test_update_attachment_fields()
• Run the same logic for empty guid for attachments that always ran in wp_insert_post(), as per #18310. This fixes a unit test that would have broken when this ticket was marked closed.
• Updated the unit test in Tests_Media::test_wp_prepare_attachment_for_js() to account for url no longer being empty

Props kovshenin, wonderboymusic.
See #21963.

File:

• trunk/tests/phpunit/tests/media.php (modified) (1 diff)

trunk/tests/phpunit/tests/media.php

@@ -149 +149 @@
         $this->assertEquals( '', $prepped['type'] );
         $this->assertEquals( '', $prepped['subtype'] );
-        $this->assertEquals( '', $prepped['url'] );
+        // #21963, there will be a guid always, so there will be a URL
+        $this->assertNotEquals( '', $prepped['url'] );
         $this->assertEquals( site_url( 'wp-includes/images/media/default.png' ), $prepped['icon'] );