Changeset 28788 for trunk/tests/phpunit/tests/post/attachments.php

Timestamp:

06/20/2014 06:26:17 PM (10 years ago)

Author:

wonderboymusic

Message:

Reinstate the changes from [28579] with some adjustments:

• Check ! empty( $postarr['file'] ) before calling update_attached_file()
• Add a unit test: test_update_attachment_fields()
• Run the same logic for empty guid for attachments that always ran in wp_insert_post(), as per #18310. This fixes a unit test that would have broken when this ticket was marked closed.
• Updated the unit test in Tests_Media::test_wp_prepare_attachment_for_js() to account for url no longer being empty

Props kovshenin, wonderboymusic.
See #21963.

File:

• trunk/tests/phpunit/tests/post/attachments.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/attachments.php

@@ -232 +232 @@
     }
 
+    /**
+     * @ticket 21963
+     */
+    function test_update_attachment_fields() {
+        $filename = ( DIR_TESTDATA . '/images/test-image.jpg' );
+        $contents = file_get_contents($filename);
+
+        $upload = wp_upload_bits( basename( $filename ), null, $contents );
+        $this->assertTrue( empty( $upload['error'] ) );
+
+        $id = $this->_make_attachment( $upload );
+
+        $attached_file = get_post_meta( $id, '_wp_attached_file', true );
+
+        $post = get_post( $id, ARRAY_A );
+
+        $post['post_title'] = 'title';
+        $post['post_excerpt'] = 'caption';
+        $post['post_content'] = 'description';
+
+        wp_update_post( $post );
+
+        // Make sure the update didn't remove the attached file.
+        $this->assertEquals( $attached_file, get_post_meta( $id, '_wp_attached_file', true ) );
+    }
+
 }