Changeset 28814 for trunk/src/wp-includes/wp-db.php

Timestamp:

06/24/2014 12:23:09 AM (11 years ago)

Author:

wonderboymusic

Message:

In $wpdb->update(), prevent explosions when $where is empty.

Adds unit tests.

Props UmeshSingla, wonderboymusic.
Fixes #26106

File:

• trunk/src/wp-includes/wp-db.php (modified) (1 diff)

trunk/src/wp-includes/wp-db.php

@@ -1786 +1786 @@
         }
 
-        $sql = "UPDATE `$table` SET " . implode( ', ', $bits ) . ' WHERE ' . implode( ' AND ', $wheres );
+        $wheres = empty( $where ) ? '' : ( ' WHERE ' . implode( ' AND ', $wheres ) );
+
+        $sql = "UPDATE `$table` SET " . implode( ', ', $bits ) . $wheres;
         return $this->query( $this->prepare( $sql, array_merge( array_values( $data ), array_values( $where ) ) ) );
     }