Changeset 28824 for trunk/src/wp-includes/comment-template.php

Timestamp:

06/24/2014 05:05:56 PM (10 years ago)

Author:

wonderboymusic

Message:

Ensure that a has_children parameter is given to Walker::start_el().

Adds unit tests.

Props scribu, obenland.
Fixes #14041.

File:

• trunk/src/wp-includes/comment-template.php (modified) (2 diffs)

trunk/src/wp-includes/comment-template.php

@@ -1785 +1785 @@
         }
 ?>
-        <<?php echo $tag; ?> <?php comment_class( empty( $args['has_children'] ) ? '' : 'parent' ); ?> id="comment-<?php comment_ID(); ?>">
+        <<?php echo $tag; ?> <?php comment_class( $this->has_children ? 'parent' : '' ); ?> id="comment-<?php comment_ID(); ?>">
         <?php if ( 'div' != $args['style'] ) : ?>
         <div id="div-comment-<?php comment_ID(); ?>" class="comment-body">
@@ -1831 +1831 @@
         $tag = ( 'div' === $args['style'] ) ? 'div' : 'li';
 ?>
-        <<?php echo $tag; ?> id="comment-<?php comment_ID(); ?>" <?php comment_class( empty( $args['has_children'] ) ? '' : 'parent' ); ?>>
+        <<?php echo $tag; ?> id="comment-<?php comment_ID(); ?>" <?php comment_class( $this->has_children ? 'parent' : '' ); ?>>
             <article id="div-comment-<?php comment_ID(); ?>" class="comment-body">
                 <footer class="comment-meta">