Changeset 28837

Timestamp:

06/26/2014 01:04:32 AM (10 years ago)

Author:

wonderboymusic

Message:

In media_buttons(), add a static var $instance to increment the id attribute of insert-media-button-%d on each call.

Props ericlewis.
Fixes #28090.

Location:

trunk/src/wp-admin

Files:

• edit-form-advanced.php (modified) (1 diff)
• includes/media.php (modified) (2 diffs)

trunk/src/wp-admin/edit-form-advanced.php

@@ -489 +489 @@
     'dfw' => true,
     'drag_drop_upload' => true,
-    'tabfocus_elements' => 'insert-media-button,save-post',
+    'tabfocus_elements' => 'insert-media-button-1,save-post',
     'editor_height' => 360,
     'tinymce' => array(

trunk/src/wp-admin/includes/media.php

@@ -515 +515 @@
  */
 function media_buttons($editor_id = 'content') {
+    static $instance = 0;
+    $instance++;
+
     $post = get_post();
     if ( ! $post && ! empty( $GLOBALS['post_ID'] ) )
@@ -525 +528 @@
     $img = '<span class="wp-media-buttons-icon"></span> ';
 
-    echo '<a href="#" id="insert-media-button" class="button insert-media add_media" data-editor="' . esc_attr( $editor_id ) . '" title="' . esc_attr__( 'Add Media' ) . '">' . $img . __( 'Add Media' ) . '</a>';
-
+    printf( '<a href="#" id="insert-media-button-%d" class="button insert-media add_media" data-editor="%s" title="%s">%s</a>',
+        $instance,
+        esc_attr( $editor_id ),
+        esc_attr__( 'Add Media' ),
+        $img . __( 'Add Media' )
+    );
     /**
      * Filter the legacy (pre-3.5.0) media buttons.