Changeset 28851

Timestamp:

06/26/2014 04:07:36 PM (10 years ago)

Author:

SergeyBiryukov

Message:

Fix unexpected replacement of a previous tag when selecting a tag from autosuggest results.

props camdensegal.
fixes #28471.

Location:

trunk/src

Files:

• wp-admin/js/inline-edit-post.js (modified) (2 diffs)
• wp-includes/js/jquery/suggest.js (modified) (2 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-admin/js/inline-edit-post.js

@@ -111 +111 @@
             // support multi taxonomies?
             tax = 'post_tag';
-            $('tr.inline-editor textarea[name="tax_input['+tax+']"]').suggest( ajaxurl + '?action=ajax-tag-search&tax=' + tax, { delay: 500, minchars: 2, multiple: true, multipleSep: inlineEditL10n.comma + ' ' } );
+            $('tr.inline-editor textarea[name="tax_input['+tax+']"]').suggest( ajaxurl + '?action=ajax-tag-search&tax=' + tax, { delay: 500, minchars: 2, multiple: true, multipleSep: inlineEditL10n.comma } );
         }
         $('html, body').animate( { scrollTop: 0 }, 'fast' );
@@ -196 +196 @@
             }
 
-            textarea.suggest( ajaxurl + '?action=ajax-tag-search&tax=' + taxname, { delay: 500, minchars: 2, multiple: true, multipleSep: inlineEditL10n.comma + ' ' } );
+            textarea.suggest( ajaxurl + '?action=ajax-tag-search&tax=' + taxname, { delay: 500, minchars: 2, multiple: true, multipleSep: inlineEditL10n.comma } );
         });
 

trunk/src/wp-includes/js/jquery/suggest.js

@@ -241 +241 @@
                 if ( options.multiple ) {
                     if ( $input.val().indexOf(options.multipleSep) != -1 ) {
-                        $currentVal = $input.val().substr( 0, ( $input.val().lastIndexOf(options.multipleSep) + options.multipleSep.length ) );
+                        $currentVal = $input.val().substr( 0, ( $input.val().lastIndexOf(options.multipleSep) + options.multipleSep.length ) ) + ' ';
                     } else {
                         $currentVal = "";
                     }
-                    $input.val( $currentVal + $currentResult.text() + options.multipleSep);
+                    $input.val( $currentVal + $currentResult.text() + options.multipleSep + ' ' );
                     $input.focus();
                 } else {
@@ -295 +295 @@
         options = options || {};
         options.multiple = options.multiple || false;
-        options.multipleSep = options.multipleSep || ", ";
+        options.multipleSep = options.multipleSep || ",";
         options.source = source;
         options.delay = options.delay || 100;

trunk/src/wp-includes/script-loader.php

@@ -477 +477 @@
             'ntdeltitle' => __('Remove From Bulk Edit'),
             'notitle' => __('(no title)'),
-            'comma' => _x( ',', 'tag delimiter' ),
+            'comma' => trim( _x( ',', 'tag delimiter' ) ),
         ) );