Changeset 28868

Timestamp:

06/27/2014 04:05:07 PM (9 years ago)

Author:

SergeyBiryukov

Message:

Avoid duplication of callbacks in theme browser sidebar each time the Next or Previous button is clicked.

This makes the collapse/expand button work as expected.

fixes #28581.

File:

• trunk/src/wp-admin/js/theme.js (modified) (5 diffs)

trunk/src/wp-admin/js/theme.js

@@ -363 +363 @@
     events: {
         'click': themes.isInstall ? 'preview': 'expand',
-        'click .preview': 'preview',
         'keydown': themes.isInstall ? 'preview': 'expand',
         'touchend': themes.isInstall ? 'preview': 'expand',
@@ -488 +487 @@
         }
 
-        // Apend preview
+        // Append preview
         $( 'div.wrap' ).append( preview.el );
 
@@ -512 +511 @@
             }
 
-            // Construct a new Preview view.
-            preview = new themes.view.Preview({
-                model: self.current
-            });
+            preview.model = self.current;
 
             // Render and append.
             preview.render();
             this.setNavButtonsState();
-            $( 'div.wrap' ).append( preview.el );
             $( '.next-theme' ).focus();
         })
@@ -546 +541 @@
             }
 
-            // Construct a new Preview view.
-            preview = new themes.view.Preview({
-                model: self.current
-            });
+            preview.model = self.current;
 
             // Render and append.
             preview.render();
             this.setNavButtonsState();
-            $( 'div.wrap' ).append( preview.el );
             $( '.previous-theme' ).focus();
         });
@@ -787 +778 @@
         themes.router.navigate( themes.router.baseUrl( '' ) );
         this.trigger( 'preview:close' );
+        this.undelegateEvents();
         this.unbind();
         return false;