WordPress.org

Make WordPress Core

Changeset 28881


Ignore:
Timestamp:
06/28/2014 04:06:12 AM (7 years ago)
Author:
wonderboymusic
Message:

In multisite, on the updated_option action, if the option name is one of: 'blogname', 'siteurl', 'post_count' - refresh the blog details cache for the current blog id.

Adds unit test.

Props kovshenin.
Fixes #26410.

Location:
trunk
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/ms-blogs.php

    r28835 r28881  
    265265
    266266/**
     267 * Refresh blog details when an option is updated.
     268 *
     269 * @access private
     270 * @param string $option_name
     271 */
     272function _wp_refresh_blog_details_on_updated_option( $option_name ) {
     273    $options = array( 'blogname', 'siteurl', 'post_count' );
     274    if ( in_array( $option_name, $options ) ) {
     275        refresh_blog_details( get_current_blog_id() );
     276    }
     277}
     278
     279/**
    267280 * Update the details for a blog. Updates the blogs table for a given blog id.
    268281 *
     
    904917        return;
    905918    }
    906    
     919
    907920    update_posts_count();
    908921}
  • trunk/src/wp-includes/ms-default-filters.php

    r28835 r28881  
    7171remove_filter( 'option_home',    '_config_wp_home'    );
    7272
     73// Some options changes should trigger blog details refresh.
     74add_action( 'updated_option', '_wp_refresh_blog_details_on_updated_option' );
     75
    7376// If the network upgrade hasn't run yet, assume ms-files.php rewriting is used.
    7477add_filter( 'default_site_option_ms_files_rewriting', '__return_true' );
  • trunk/tests/phpunit/tests/ms.php

    r28835 r28881  
    13981398        $this->assertEquals( 1, get_blog_details()->post_count );
    13991399    }
     1400
     1401    /**
     1402     * @ticket 26410
     1403     */
     1404    function test_blog_details_cache_invalidation() {
     1405        update_option( 'blogname', 'foo' );
     1406        $details = get_blog_details( get_current_blog_id() );
     1407        $this->assertEquals( 'foo', $details->blogname );
     1408
     1409        update_option( 'blogname', 'bar' );
     1410        $details = get_blog_details( get_current_blog_id() );
     1411        $this->assertEquals( 'bar', $details->blogname );
     1412    }
    14001413}
    14011414
Note: See TracChangeset for help on using the changeset viewer.