Changeset 28897

Timestamp:

06/29/2014 04:05:53 PM (11 years ago)

Author:

SergeyBiryukov

Message:

Fix feature pointer positioning issues for both LTR and RTL.

fixes #28062.

Location:

trunk/src

Files:

• wp-admin/includes/template.php (modified) (2 diffs)
• wp-includes/css/wp-pointer.css (modified) (7 diffs)

trunk/src/wp-admin/includes/template.php

@@ -1993 +1993 @@
         self::print_js( 'wp360_revisions', '.misc-pub-section.misc-pub-revisions', array(
             'content' => $content,
-            'position' => array( 'edge' => is_rtl() ? 'left' : 'right', 'align' => 'center', 'my' => is_rtl() ? 'left' : 'right-14px' ),
+            'position' => array( 'edge' => is_rtl() ? 'left' : 'right', 'align' => 'center' ),
         ) );
     }
@@ -2021 +2021 @@
         if ( 'themes' === get_current_screen()->id ) {
             $selector = '.theme.active .customize';
-            $position = array( 'edge' => is_rtl() ? 'right' : 'left', 'align' => 'center', 'my' => is_rtl() ? 'right-13px' : '' );
+            $position = array( 'edge' => is_rtl() ? 'right' : 'left', 'align' => 'center' );
         } else {
             $selector = 'a[href="customize.php"]';

trunk/src/wp-includes/css/wp-pointer.css

@@ -107 +107 @@
 
 .wp-pointer-bottom {
+    margin-top: -13px;
     padding-bottom: 13px;
 }
@@ -116 +117 @@
 /* @noflip */
 .wp-pointer-right {
+    margin-left: -13px;
     padding-right: 13px;
 }
@@ -140 +142 @@
 }
 
-.wp-pointer-top .wp-pointer-arrow:before,
-.wp-pointer-undefined .wp-pointer-arrow:before {
-    margin-left: -13px;
-    margin-top: -11px;
+.wp-pointer-top .wp-pointer-arrow-inner,
+.wp-pointer-undefined .wp-pointer-arrow-inner {
+    top: 1px;
+    margin-left: -13px;
+    margin-top: -13px;
     border: 13px solid transparent;
     border-bottom-color: #2ea2cc;
@@ -156 +159 @@
 }
 
-.wp-pointer-bottom .wp-pointer-arrow:before {
-    margin-left: -13px;
-    margin-top: -14px;
+.wp-pointer-bottom .wp-pointer-arrow-inner {
+    bottom: 1px;
+    margin-left: -13px;
+    margin-bottom: -13px;
     border: 13px solid transparent;
     border-top-color: #fff;
@@ -172 +176 @@
 }
 
-.wp-pointer-left .wp-pointer-arrow:before {
-    margin-left: -14px;
+/* @noflip */
+.wp-pointer-left .wp-pointer-arrow-inner {
+    left: 1px;
+    margin-left: -13px;
     margin-top: -13px;
     border: 13px solid transparent;
@@ -183 +189 @@
 /* @noflip */
 .wp-pointer-right .wp-pointer-arrow {
-    right:0;
+    right: 0;
     border-width: 13px 0 13px 13px;
     border-left-color: #ccc;
 }
 
-.wp-pointer-right .wp-pointer-arrow:before {
-    margin-left: -14px;
+/* @noflip */
+.wp-pointer-right .wp-pointer-arrow-inner {
+    right: 1px;
+    margin-right: -13px;
     margin-top: -13px;
     border: 13px solid transparent;
@@ -195 +203 @@
     display: block;
     content: ' ';
-}
-
-.rtl .wp-pointer-arrow:before {
-    -webkit-transform: rotateY(180deg);
-    -ms-transform:     rotateY(180deg);
-    transform:         rotateY(180deg);
 }