Changeset 28916

Timestamp:

06/30/2014 01:09:25 AM (10 years ago)

Author:

SergeyBiryukov

Message:

Prevent bulk actions from being performed when Filter button is clicked.

props jesin.
fixes #28555.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-comments-list-table.php (modified) (1 diff)
• class-wp-links-list-table.php (modified) (1 diff)
• class-wp-list-table.php (modified) (1 diff)
• class-wp-media-list-table.php (modified) (1 diff)
• class-wp-posts-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -259 +259 @@
              */
             do_action( 'restrict_manage_comments' );
-            submit_button( __( 'Filter' ), 'button', false, false, array( 'id' => 'post-query-submit' ) );
+            submit_button( __( 'Filter' ), 'button', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
         }
 

trunk/src/wp-admin/includes/class-wp-links-list-table.php

@@ -70 +70 @@
             );
             wp_dropdown_categories( $dropdown_options );
-            submit_button( __( 'Filter' ), 'button', false, false, array( 'id' => 'post-query-submit' ) );
+            submit_button( __( 'Filter' ), 'button', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
 ?>
         </div>

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -385 +385 @@
      */
     public function current_action() {
+        if ( isset( $_REQUEST['filter_action'] ) && ! empty( $_REQUEST['filter_action'] ) )
+            return false;
+
         if ( isset( $_REQUEST['action'] ) && -1 != $_REQUEST['action'] )
             return $_REQUEST['action'];

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -95 +95 @@
             /** This action is documented in wp-admin/includes/class-wp-posts-list-table.php */
             do_action( 'restrict_manage_posts' );
-            submit_button( __( 'Filter' ), 'button', false, false, array( 'id' => 'post-query-submit' ) );
+            submit_button( __( 'Filter' ), 'button', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
         }
 

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -234 +234 @@
             do_action( 'restrict_manage_posts' );
 
-            submit_button( __( 'Filter' ), 'button', false, false, array( 'id' => 'post-query-submit' ) );
+            submit_button( __( 'Filter' ), 'button', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
         }