Changeset 28940

Timestamp:

07/01/2014 04:22:32 PM (11 years ago)

Author:

helen

Message:

Only apply metabox handle styles and JS events to .postbox .hndle, as opposed to all h3s in a .postbox.

Developers previously relying on the h3 behavior may be affected. You may want to investigate do_meta_boxes() rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.

Location:

trunk/src/wp-admin

Files:

• css/common.css (modified) (4 diffs)
• css/ie.css (modified) (1 diff)
• js/postbox.js (modified) (2 diffs)

trunk/src/wp-admin/css/common.css

@@ -706 +706 @@
 
 .widget .widget-top,
-.postbox h3,
-.stuffbox h3,
+.postbox .hndle,
+.stuffbox .hndle,
 .control-section .accordion-section-title,
 h3.dashboard-widget-title,
@@ -730 +730 @@
 }
 
-.postbox h3,
-#namediv h3,
-#submitdiv h3 {
+.postbox .hndle,
+.stuffbox .hndle {
     border-bottom: 1px solid #eee;
 }
@@ -1350 +1349 @@
 }
 
+.js .widget .widget-top,
 .js .postbox .hndle {
     cursor: move;
@@ -1381 +1381 @@
 }
 
-.postbox h3,
-.stuffbox h3 {
-    margin-top: 1px;
+/* user-select is not a part of the CSS standard - may change behavior in the future */
+.postbox .hndle,
+.stuffbox .hndle {
     -webkit-user-select: none;
     -moz-user-select: none;
     -ms-user-select: none;
     user-select: none;
-}
-
-.js .widget .widget-top,
-.js .postbox h3 {
-    cursor: move;
 }
 

trunk/src/wp-admin/css/ie.css

@@ -261 +261 @@
 }
 
-#wpbody-content .postbox h3 {
+#wpbody-content .postbox .hndle {
     margin-bottom: -1px;
 }

trunk/src/wp-admin/js/postbox.js

@@ -10 +10 @@
             self.init(page, args);
 
-            $('.postbox h3, .postbox .handlediv').bind('click.postboxes', function() {
+            $('.postbox .hndle, .postbox .handlediv').bind('click.postboxes', function() {
                 var p = $(this).parent('.postbox'), id = p.attr('id');
 
@@ -29 +29 @@
             });
 
-            $('.postbox h3 a').click( function(e) {
+            $('.postbox .hndle a').click( function(e) {
                 e.stopPropagation();
             });