Changeset 28965

Timestamp:

07/03/2014 01:16:33 AM (11 years ago)

Author:

wonderboymusic

Message:

Transient timeouts are untestable when WP_INSTALLING is defined and set to ANY value. Transient timeouts cannot be tested during multisite runs because wpmu_create_blog() sets WP_INSTALLING. I have zero idea how these tests ever passed.

See #28706.

Location:

trunk/tests/phpunit

Files:

• includes/install.php (modified) (1 diff)
• tests/option/transient.php (modified) (2 diffs)

trunk/tests/phpunit/includes/install.php

@@ -10 +10 @@
 $multisite = ! empty( $argv[2] );
 
-define( 'WP_INSTALLING', true );
 require_once $config_file_path;
 require_once dirname( __FILE__ ) . '/functions.php';

trunk/tests/phpunit/tests/option/transient.php

@@ -39 +39 @@
      */
     function test_transient_data_with_timeout() {
+        if ( is_multisite() ) {
+            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING.' );
+        }
+
         $key = rand_str();
         $value = rand_str();
@@ -60 +64 @@
      */
     function test_transient_add_timeout() {
+        if ( is_multisite() ) {
+            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING.' );
+        }
+
         $key = rand_str();
         $value = rand_str();