WordPress.org

Make WordPress Core

Changeset 28965


Ignore:
Timestamp:
07/03/2014 01:16:33 AM (7 years ago)
Author:
wonderboymusic
Message:

Transient timeouts are untestable when WP_INSTALLING is defined and set to ANY value. Transient timeouts cannot be tested during multisite runs because wpmu_create_blog() sets WP_INSTALLING. I have zero idea how these tests ever passed.

See #28706.

Location:
trunk/tests/phpunit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/includes/install.php

    r26944 r28965  
    1010$multisite = ! empty( $argv[2] );
    1111
    12 define( 'WP_INSTALLING', true );
    1312require_once $config_file_path;
    1413require_once dirname( __FILE__ ) . '/functions.php';
  • trunk/tests/phpunit/tests/option/transient.php

    r28962 r28965  
    3939     */
    4040    function test_transient_data_with_timeout() {
     41        if ( is_multisite() ) {
     42            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING.' );
     43        }
     44
    4145        $key = rand_str();
    4246        $value = rand_str();
     
    6064     */
    6165    function test_transient_add_timeout() {
     66        if ( is_multisite() ) {
     67            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING.' );
     68        }
     69
    6270        $key = rand_str();
    6371        $value = rand_str();
Note: See TracChangeset for help on using the changeset viewer.