Changeset 29045

Timestamp:

07/09/2014 06:15:42 PM (11 years ago)

Author:

nacin

Message:

WP_Comment_Query: Add fields => 'ids' query var.

props mordauk.
fixes #28434.

Location:

trunk

Files:

• src/wp-includes/comment.php (modified) (3 diffs)
• tests/phpunit/tests/comment/query.php (modified) (1 diff)

trunk/src/wp-includes/comment.php

@@ -246 +246 @@
         $defaults = array(
             'author_email' => '',
+            'fields' => '',
             'ID' => '',
             'karma' => '',
@@ -369 +370 @@
             $fields = 'COUNT(*)';
         } else {
-            $fields = '*';
-        }
+            switch ( strtolower( $this->query_vars['fields'] ) ) {
+                case 'ids':
+                    $fields = "$wpdb->comments.comment_ID";
+                    break;
+                default:
+                    $fields = "*";
+                    break;
+            }
+        }
+
         $join = '';
         $where = $approved;
@@ -461 +470 @@
             return $wpdb->get_var( $query );
         }
+
+        if ( 'ids' == $this->query_vars['fields'] ) {
+            $this->comments = $wpdb->get_col( $query );
+            return array_map( 'intval', $this->comments );
+        }
+
         $results = $wpdb->get_results( $query );
         /**

trunk/tests/phpunit/tests/comment/query.php

@@ -181 +181 @@
 
     }
+
+    /**
+     * @ticket 28434
+     */
+    function test_fields_ids_query() {
+        $comment_1 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'user_id' => 7, 'comment_approved' => '1' ) );
+        $comment_2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'user_id' => 1, 'comment_approved' => '1' ) );
+        $comment_3 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'user_id' => 1, 'comment_approved' => '1' ) );
+
+        // Ensure we are dealing with integers, and not objects.
+        $this->assertInternalType( 'integer', $comment_1 );
+        $this->assertInternalType( 'integer', $comment_2 );
+        $this->assertInternalType( 'integer', $comment_3 );
+
+        $comment_ids = get_comments( array( 'fields' => 'ids' ) );
+        $this->assertCount( 3, $comment_ids );
+        $this->assertEquals( array( $comment_1, $comment_2, $comment_3 ), $comment_ids );
+    }
 }