Changeset 29063

Timestamp:

07/10/2014 02:16:20 PM (11 years ago)

Author:

westi

Message:

XMLRPC: Restore support in wp.newPost for dates to be supplied in the structured dateTime.iso8601 format as well as still supporting dates specified as strings.

Fixes #28601.

Location:

trunk

Files:

• src/wp-includes/class-wp-xmlrpc-server.php (modified) (2 diffs)
• tests/phpunit/tests/xmlrpc/wp/newPost.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -1104 +1104 @@
 
         // convert the date field back to IXR form
-        if ( isset( $content_struct['post_date'] ) ) {
+        if ( isset( $content_struct['post_date'] ) && ! is_a( $content_struct['post_date'], 'IXR_Date' ) ) {
             $content_struct['post_date'] = $this->_convert_date( $content_struct['post_date'] );
         }
@@ -1110 +1110 @@
         // ignore the existing GMT date if it is empty or a non-GMT date was supplied in $content_struct,
         // since _insert_post will ignore the non-GMT date if the GMT date is set
-        if ( isset( $content_struct['post_date_gmt'] ) ) {
+        if ( isset( $content_struct['post_date_gmt'] ) && ! is_a( $content_struct['post_date_gmt'], 'IXR_Date' ) ) {
             if ( $content_struct['post_date_gmt'] == '0000-00-00 00:00:00' || isset( $content_struct['post_date'] ) ) {
                 unset( $content_struct['post_date_gmt'] );

trunk/tests/phpunit/tests/xmlrpc/wp/newPost.php

@@ -358 +358 @@
     }
 
+    /**
+     * @ticket 28601
+     */
+    function test_valid_IXR_post_date() {
+        $this->make_user_by_role( 'author' );
+        $date_string = '1984-01-11 05:00:00';
+        $post = array( 'post_title' => 'test', 'post_content' => 'test', 'post_date' => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date_string, false ) ) );
+        $result = $this->myxmlrpcserver->wp_newPost( array( 1, 'author', 'author', $post ) );
+        $fetched_post = get_post( $result );
+        $this->assertStringMatchesFormat( '%d', $result );
+        $this->assertEquals( $date_string , $fetched_post->post_date );
+    }
+
+    /**
+     * @ticket 28601
+     */
+    function test_valid_IXR_post_date_gmt() {
+        $this->make_user_by_role( 'author' );
+        $date_string = '1984-01-11 05:00:00';
+        $post = array( 'post_title' => 'test', 'post_content' => 'test', 'post_date_gmt' => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date_string, false ) ) );
+        $result = $this->myxmlrpcserver->wp_newPost( array( 1, 'author', 'author', $post ) );
+        $fetched_post = get_post( $result );
+        $this->assertStringMatchesFormat( '%d', $result );
+        $this->assertEquals( $date_string , $fetched_post->post_date_gmt );
+    }
+
 }