Changeset 29077 for trunk/src/wp-includes/media-template.php

Timestamp:

07/10/2014 08:59:12 PM (11 years ago)

Author:

wonderboymusic

Message:

Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.

See #24716.

File:

• trunk/src/wp-includes/media-template.php (modified) (2 diffs)

trunk/src/wp-includes/media-template.php

@@ -230 +230 @@
     </script>
 
-    <script type="text/html" id="tmpl-media-grid-field-options">
-        <label class="setting">
-            <span><?php _e( 'Name' ); ?></span>
-            <input type="checkbox" data-setting="title" {{ '' === getUserSetting( 'hidegridtitle' ) && 'checked' }} />
-        </label>
-        <label class="setting">
-            <span><?php _e( 'Uploaded to' ); ?></span>
-            <input type="checkbox" data-setting="uploadedTo" {{ '' === getUserSetting( 'hidegriduploadedTo' ) && 'checked' }} />
-        </label>
-        <label class="setting">
-            <span><?php _e( 'Date' ); ?></span>
-            <input type="checkbox" data-setting="dateFormatted" {{ '' === getUserSetting( 'hidegriddateFormatted' ) && 'checked' }} />
-        </label>
-        <label class="setting">
-            <span><?php _e( 'Mime-type' ); ?></span>
-            <input type="checkbox" data-setting="mime" {{ '' === getUserSetting( 'hidegridmime' ) && 'checked' }} />
-        </label>
-    </script>
-
     <script type="text/html" id="tmpl-uploader-status">
         <h3><?php _e( 'Uploading' ); ?></h3>
@@ -438 +419 @@
         if ( _.contains( data.controller.options.mode, 'grid' ) ) { #>
         <div class="data-fields">
-        <# _.each( data.showAttachmentFields, function( field ) {
-            var className = 'data-field data-hidden';
-            if ( '' === getUserSetting( 'hidegrid' + field ) ) {
-                className = 'data-field data-visible';
-            }
-        #>
-            <div class="{{ className }} data-{{ field }}"><#
-                if ( 'uploadedTo' === field ) {
-                    if ( data[ field ] ) {
+        <?php
+        $hidden = get_hidden_columns( get_current_screen() );
+        $fields = array( 'title', 'uploadedTo', 'dateFormatted', 'mime' );
+        foreach ( $fields as $field ):
+            $class_name = in_array( $field, $hidden ) ? 'data-field data-hidden' : 'data-field data-visible';
+        ?>
+            <div class="<?php echo $class_name ?> data-<?php echo $field ?>"><#
+                if ( 'uploadedTo' === '<?php echo $field ?>' ) {
+                    if ( data[ '<?php echo $field ?>' ] ) {
                     #><?php _e( 'Uploaded To: ' ) ?><a href="{{ data.uploadedToLink }}">{{ data.uploadedToTitle }}</a><#
                     } else {
                     #><?php _e( 'Unattached' ) ?><#
                     }
-                } else if ( 'title' === field && ! data[ field ] ) {
+                } else if ( 'title' === '<?php echo $field ?>' && ! data[ '<?php echo $field ?>' ] ) {
                 #><?php _e( '(No title)' ) ?><#
-                } else if ( data[ field ] ) {
-                #>{{ data[ field ] }}<#
+                } else if ( data[ '<?php echo $field ?>' ] ) {
+                #>{{ data[ '<?php echo $field ?>' ] }}<#
                 }
             #></div>
-        <# }); #>
+        <?php endforeach ?>
         </div>
         <# } #>