Changeset 29118

Timestamp:

07/12/2014 03:26:40 AM (12 years ago)

Author:

wonderboymusic

Message:

Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.

Props SergeyBiryukov.
See #28843 and [28583].

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-links-list-table.php (modified) (1 diff)
• class-wp-list-table.php (modified) (2 diffs)
• class-wp-media-list-table.php (modified) (1 diff)
• class-wp-ms-sites-list-table.php (modified) (1 diff)
• class-wp-ms-themes-list-table.php (modified) (1 diff)
• class-wp-ms-users-list-table.php (modified) (1 diff)
• class-wp-plugin-install-list-table.php (modified) (1 diff)
• class-wp-plugins-list-table.php (modified) (1 diff)
• class-wp-posts-list-table.php (modified) (1 diff)
• class-wp-terms-list-table.php (modified) (1 diff)
• class-wp-themes-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-links-list-table.php

@@ -76 +76 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 return array(
                         'cb'         => '<input type="checkbox" />',

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -539 +539 @@
          *
          * @since 3.1.0
-         * @access protected
+         * @access public
          *
          * @return int
          */
-        protected function get_pagenum() {
+        public function get_pagenum() {
                 $pagenum = isset( $_REQUEST['paged'] ) ? absint( $_REQUEST['paged'] ) : 0;
 
@@ -676 +676 @@
          *
          * @since 3.1.0
-         * @access protected
+         * @access public
          * @abstract
          *
          * @return array
          */
-        protected function get_columns() {
+        public function get_columns() {
                 die( 'function WP_List_Table::get_columns() must be over-ridden in a sub-class.' );
         }

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -171 +171 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 $posts_columns = array();
                 $posts_columns['cb'] = '<input type="checkbox" />';

trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -144 +144 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 $blogname_columns = ( is_subdomain_install() ) ? __( 'Domain' ) : __( 'Path' );
                 $sites_columns = array(

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -175 +175 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 global $status;
 

trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -109 +109 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 $users_columns = array(
                         'cb'         => '<input type="checkbox" />',

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -208 +208 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 return array(
                         'name'        => _x( 'Name', 'plugin name' ),

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -211 +211 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 global $status;
 

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -265 +265 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 $post_type = $this->screen->post_type;
 

trunk/src/wp-admin/includes/class-wp-terms-list-table.php

@@ -117 +117 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 $columns = array(
                         'cb'          => '<input type="checkbox" />',

trunk/src/wp-admin/includes/class-wp-themes-list-table.php

@@ -111 +111 @@
         }
 
-        protected function get_columns() {
+        public function get_columns() {
                 return array();
         }