Changeset 29119

Timestamp:

07/12/2014 03:53:34 AM (11 years ago)

Author:

wonderboymusic

Message:

The 2nd argument to array_unique() was added to PHP in 5.2.9, so don't use it. We have to use our own code to return unique terms when fields => all in wp_get_object_terms().

See #28843 and [28583].

File:

• trunk/src/wp-includes/taxonomy.php (modified) (3 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -2322 +2322 @@
     $query = "SELECT $select_this FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy AS tt ON tt.term_id = t.term_id INNER JOIN $wpdb->term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tt.taxonomy IN ($taxonomies) AND tr.object_id IN ($object_ids) $orderby $order";
 
+    $objects = false;
     if ( 'all' == $fields || 'all_with_object_id' == $fields ) {
         $_terms = $wpdb->get_results( $query );
@@ -2329 +2330 @@
         $terms = array_merge( $terms, $_terms );
         update_term_cache( $terms );
+        $objects = true;
     } else if ( 'ids' == $fields || 'names' == $fields || 'slugs' == $fields ) {
         $_terms = $wpdb->get_col( $query );
@@ -2345 +2347 @@
     if ( ! $terms ) {
         $terms = array();
-    } else {
-        $terms = array_values( array_unique( $terms, SORT_REGULAR ) );
+    } elseif ( $objects && 'all_with_object_id' !== $fields ) {
+        $_tt_ids = array();
+        $_terms = array();
+        foreach ( $terms as $term ) {
+            if ( in_array( $term->term_taxonomy_id, $_tt_ids ) ) {
+                continue;
+            }
+
+            $_tt_ids[] = $term->term_taxonomy_id;
+            $_terms[] = $term;
+        }
+        $terms = $_terms;
+    } elseif ( ! $objects ) {
+        $terms = array_values( array_unique( $terms ) );
     }
     /**