Changeset 29133

Timestamp:

07/13/2014 11:04:21 AM (12 years ago)

Author:

ocean90

Message:

Lists View Switcher: Replace blank image with screen reader text.

props davidakennedy.
fixes #28871.

Location:

trunk/src

Files:

• wp-admin/css/list-tables.css (modified) (1 diff)
• wp-admin/includes/class-wp-list-table.php (modified) (1 diff)
• wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)
• wp-includes/media-template.php (modified) (1 diff)

trunk/src/wp-admin/css/list-tables.css

@@ -619 +619 @@
 }
 
-.view-switch img {
-        display: none;
-}
-
 .view-switch a {
         text-decoration: none;

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -501 +501 @@
                                         $classes[] = 'current';
                                 printf(
-                                        "<a href='%s' class='%s'><img id='view-switch-$mode' src='%s' width='20' height='20' title='%s' alt='%s' /></a>\n",
+                                        "<a href='%s' class='%s' id='view-switch-$mode'><span class='screen-reader-text'>%s</span></a>\n",
                                         esc_url( add_query_arg( 'mode', $mode ) ),
                                         implode( ' ', $classes ),
-                                        esc_url( includes_url( 'images/blank.gif' ) ),
-                                        $title,
                                         $title
                                 );

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -157 +157 @@
                                         $classes[] = 'current';
                                 printf(
-                                        "<a href='%s' class='%s'><img id='view-switch-$mode' src='%s' width='20' height='20' title='%s' alt='%s' /></a>\n",
+                                        "<a href='%s' class='%s' id='view-switch-$mode'><span class='screen-reader-text'>%s</span></a>\n",
                                         esc_url( add_query_arg( 'mode', $mode ) ),
                                         implode( ' ', $classes ),
-                                        esc_url( includes_url( 'images/blank.gif' ) ),
-                                        $title,
                                         $title
-
                                 );
                         }

trunk/src/wp-includes/media-template.php

@@ -226 +226 @@
         <script type="text/html" id="tmpl-media-library-view-switcher">
                 <a href="<?php echo esc_url( add_query_arg( 'mode', 'list', $_SERVER['REQUEST_URI'] ) ) ?>" class="view-list">
-                        <img id="view-switch-list" src="<?php echo includes_url( 'images/blank.gif' ) ?>" width="20" height="20" title="List View" alt="List View"/>
+                        <span class="screen-reader-text"><?php _e( 'List View' ); ?></span>
                 </a>
                 <a href="<?php echo esc_url( add_query_arg( 'mode', 'grid', $_SERVER['REQUEST_URI'] ) ) ?>" class="view-grid current">
-                        <img id="view-switch-excerpt" src="<?php echo includes_url( 'images/blank.gif' ) ?>" width="20" height="20" title="Grid View" alt="Grid View"/>
+                        <span class="screen-reader-text"><?php _e( 'Grid View' ); ?></span>
                 </a>
         </script>