WordPress.org

Make WordPress Core

Changeset 29137


Ignore:
Timestamp:
07/13/2014 10:08:22 PM (5 years ago)
Author:
wonderboymusic
Message:

Fix mismatches in access modifiers for WP_List_Table + subclasses.

Fixes #28843, #28879.

Location:
trunk/src/wp-admin/includes
Files:
14 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-comments-list-table.php

    r28916 r29137  
    149149    }
    150150
    151     public function get_views() {
     151    protected function get_views() {
    152152        global $post_id, $comment_status, $comment_type;
    153153
     
    202202    }
    203203
    204     public function get_bulk_actions() {
     204    protected function get_bulk_actions() {
    205205        global $comment_status;
    206206
     
    226226    }
    227227
    228     public function extra_tablenav( $which ) {
     228    protected function extra_tablenav( $which ) {
    229229        global $comment_status, $comment_type;
    230230?>
     
    302302    }
    303303
    304     public function get_sortable_columns() {
     304    protected function get_sortable_columns() {
    305305        return array(
    306306            'author'   => 'comment_author',
     
    583583class WP_Post_Comments_List_Table extends WP_Comments_List_Table {
    584584
    585     public function get_column_info() {
     585    protected function get_column_info() {
    586586        $this->_column_headers = array(
    587587            array(
     
    596596    }
    597597
    598     public function get_table_classes() {
     598    protected function get_table_classes() {
    599599        $classes = parent::get_table_classes();
    600600        $classes[] = 'comments-box';
  • trunk/src/wp-admin/includes/class-wp-links-list-table.php

    r29118 r29137  
    9797    }
    9898
    99     protected function display_rows() {
     99    public function display_rows() {
    100100        global $cat_id;
    101101
  • trunk/src/wp-admin/includes/class-wp-list-table.php

    r29133 r29137  
    334334     *
    335335     * @since 3.1.0
    336      * @access public
    337      */
    338     public function bulk_actions() {
     336     * @access protected
     337     */
     338    protected function bulk_actions() {
    339339        if ( is_null( $this->_actions ) ) {
    340340            $no_new_actions = $this->_actions = $this->get_bulk_actions();
     
    763763     *
    764764     * @since 3.1.0
    765      * @access protected
     765     * @access public
    766766     *
    767767     * @param bool $with_id Whether to set the id attribute or not
    768768     */
    769     protected function print_column_headers( $with_id = true ) {
     769    public function print_column_headers( $with_id = true ) {
    770770        list( $columns, $hidden, $sortable ) = $this->get_column_info();
    771771
     
    914914     *
    915915     * @since 3.1.0
    916      * @access protected
    917      */
    918     protected function display_rows_or_placeholder() {
     916     * @access public
     917     */
     918    public function display_rows_or_placeholder() {
    919919        if ( $this->has_items() ) {
    920920            $this->display_rows();
     
    930930     *
    931931     * @since 3.1.0
    932      * @access protected
    933      */
    934     protected function display_rows() {
     932     * @access public
     933     */
     934    public function display_rows() {
    935935        foreach ( $this->items as $item )
    936936            $this->single_row( $item );
     
    941941     *
    942942     * @since 3.1.0
    943      * @access protected
     943     * @access public
    944944     *
    945945     * @param object $item The current item
    946946     */
    947     protected function single_row( $item ) {
     947    public function single_row( $item ) {
    948948        static $row_class = '';
    949949        $row_class = ( $row_class == '' ? ' class="alternate"' : '' );
     
    10291029     * Send required variables to JavaScript land
    10301030     *
    1031      * @access private
    1032      */
    1033     private function _js_vars() {
     1031     * @access public
     1032     */
     1033    public function _js_vars() {
    10341034        $args = array(
    10351035            'class'  => get_class( $this ),
  • trunk/src/wp-admin/includes/class-wp-media-list-table.php

    r29133 r29137  
    233233    }
    234234
    235     protected function display_rows() {
     235    public function display_rows() {
    236236        global $post;
    237237
  • trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

    r29118 r29137  
    251251    }
    252252
    253     protected function display_rows() {
     253    public function display_rows() {
    254254        foreach ( $this->items as $theme )
    255255            $this->single_row( $theme );
    256256    }
    257257
    258     protected function single_row( $theme ) {
     258    public function single_row( $theme ) {
    259259        global $status, $page, $s, $totals;
    260260
  • trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

    r29118 r29137  
    140140    }
    141141
    142     protected function display_rows() {
     142    public function display_rows() {
    143143        global $mode;
    144144
  • trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

    r29118 r29137  
    217217    }
    218218
    219     protected function display_rows() {
     219    public function display_rows() {
    220220        $plugins_allowedtags = array(
    221221            'a' => array( 'href' => array(),'title' => array(), 'target' => array() ),
  • trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

    r29118 r29137  
    324324    }
    325325
    326     protected function display_rows() {
     326    public function display_rows() {
    327327        global $status;
    328328
     
    334334    }
    335335
    336     protected function single_row( $item ) {
     336    public function single_row( $item ) {
    337337        global $status, $page, $s, $totals;
    338338
  • trunk/src/wp-admin/includes/class-wp-posts-list-table.php

    r29118 r29137  
    359359    }
    360360
    361     protected function display_rows( $posts = array(), $level = 0 ) {
     361    public function display_rows( $posts = array(), $level = 0 ) {
    362362        global $wp_query, $per_page;
    363363
     
    526526    }
    527527
    528     protected function single_row( $post, $level = 0 ) {
     528    public function single_row( $post, $level = 0 ) {
    529529        global $mode;
    530530        static $alternate;
  • trunk/src/wp-admin/includes/class-wp-terms-list-table.php

    r29118 r29137  
    145145    }
    146146
    147     protected function display_rows_or_placeholder() {
     147    public function display_rows_or_placeholder() {
    148148        $taxonomy = $this->screen->taxonomy;
    149149
     
    241241    }
    242242
    243     protected function single_row( $tag, $level = 0 ) {
     243    public function single_row( $tag, $level = 0 ) {
    244244        global $taxonomy;
    245245        $tag = sanitize_term( $tag, $taxonomy );
  • trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

    r29002 r29137  
    177177    }
    178178
    179     protected function display_rows() {
     179    public function display_rows() {
    180180        $themes = $this->items;
    181181        foreach ( $themes as $theme ) {
     
    208208     *     public 'download_link' => string 'http://wordpress.org/themes/download/magazine-basic.1.1.zip'
    209209     */
    210     protected function single_row( $theme ) {
     210    public function single_row( $theme ) {
    211211        global $themes_allowedtags;
    212212
     
    397397     *
    398398     * @since 3.4.0
    399      * @access private
     399     * @access public
    400400     *
    401401     * @uses $tab Global; current tab within Themes->Install screen
    402402     * @uses $type Global; type of search.
    403403     */
    404     private function _js_vars( $extra_args = array() ) {
     404    public function _js_vars( $extra_args = array() ) {
    405405        global $tab, $type;
    406406        parent::_js_vars( compact( 'tab', 'type' ) );
  • trunk/src/wp-admin/includes/class-wp-themes-list-table.php

    r29118 r29137  
    115115    }
    116116
    117     protected function display_rows_or_placeholder() {
     117    public function display_rows_or_placeholder() {
    118118        if ( $this->has_items() ) {
    119119            $this->display_rows();
     
    125125    }
    126126
    127     protected function display_rows() {
     127    public function display_rows() {
    128128        $themes = $this->items;
    129129
     
    244244     *
    245245     * @since 3.4.0
    246      * @access private
     246     * @access public
    247247     *
    248248     * @uses $this->features Array of all feature search terms.
     
    250250     * @uses _pagination_args['total_pages']
    251251     */
    252     private function _js_vars( $extra_args = array() ) {
     252    public function _js_vars( $extra_args = array() ) {
    253253        $search_string = isset( $_REQUEST['s'] ) ? esc_attr( wp_unslash( $_REQUEST['s'] ) ) : '';
    254254
  • trunk/src/wp-admin/includes/class-wp-users-list-table.php

    r28497 r29137  
    128128     *
    129129     * @since  3.1.0
    130      * @access public
     130     * @access protected
    131131     *
    132132     * @return array An array of HTML links, one for each view.
    133133     */
    134     public function get_views() {
     134    protected function get_views() {
    135135        global $wp_roles, $role;
    136136
     
    174174     *
    175175     * @since  3.1.0
    176      * @access public
     176     * @access protected
    177177     *
    178178     * @return array Array of bulk actions.
    179179     */
    180     public function get_bulk_actions() {
     180    protected function get_bulk_actions() {
    181181        $actions = array();
    182182
     
    196196     *
    197197     * @since 3.1.0
    198      * @access public
     198     * @access protected
    199199     *
    200200     * @param string $which Whether this is being invoked above ("top")
    201201     *                      or below the table ("bottom").
    202202     */
    203     public function extra_tablenav( $which ) {
     203    protected function extra_tablenav( $which ) {
    204204        if ( 'top' != $which )
    205205            return;
     
    273273     *
    274274     * @since 3.1.0
    275      * @access public
     275     * @access protected
    276276     *
    277277     * @return array Array of sortable columns.
    278278     */
    279     public function get_sortable_columns() {
     279    protected function get_sortable_columns() {
    280280        $c = array(
    281281            'username' => 'login',
  • trunk/src/wp-admin/includes/list-table.php

    r28531 r29137  
    100100    }
    101101
    102     public function get_column_info() {
     102    protected function get_column_info() {
    103103        $columns = get_column_headers( $this->_screen );
    104104        $hidden = get_hidden_columns( $this->_screen );
Note: See TracChangeset for help on using the changeset viewer.