Changeset 29196 for trunk/src/wp-includes/taxonomy.php

Timestamp:

07/16/2014 09:51:40 PM (10 years ago)

Author:

wonderboymusic

Message:

Avoid a race condition when multiple windows are open so that orphaned terms cannot be created by accident.

Adds a unit test.

Props dlh.
Fixes #19205.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -2419 +2419 @@
     }
     $defaults = array( 'alias_of' => '', 'description' => '', 'parent' => 0, 'slug' => '');
-    $args = wp_parse_args($args, $defaults);
+    $args = wp_parse_args( $args, $defaults );
+
+    if ( $args['parent'] > 0 && ! term_exists( (int) $args['parent'] ) ) {
+        return new WP_Error( 'missing_parent', __( 'The selected parent term no longer exists' ) );
+    }
     $args['name'] = $term;
     $args['taxonomy'] = $taxonomy;