Changeset 29202

Timestamp:

07/17/2014 12:49:11 AM (10 years ago)

Author:

azaozz

Message:

TinyMCE wpView: prevent fatal (security) errors when trying to access iframe.contentWindow in pausePlayers() and unsetPlayers(). See #28905.

File:

• trunk/src/wp-includes/js/mce-view.js (modified) (3 diffs)

trunk/src/wp-includes/js/mce-view.js

@@ -133 +133 @@
                         allowTransparency: 'true',
                         scrolling: 'no',
+                        'class': 'wpview-sandbox',
                         style: {
                             width: '100%',
@@ -555 +556 @@
             pausePlayers: function() {
                 this.getNodes( function( editor, node, content ) {
-                    var p, win = $( 'iframe', content ).get(0).contentWindow;
-
-                    if ( win && win.mejs ) {
+                    var p, win,
+                        iframe = $( 'iframe.wpview-sandbox', content ).get(0);
+
+                    if ( iframe && ( win = iframe.contentWindow ) && win.mejs ) {
                         for ( p in win.mejs.players ) {
                             win.mejs.players[p].pause();
@@ -567 +569 @@
             unsetPlayers: function() {
                 this.getNodes( function( editor, node, content ) {
-                    var p, win = $( 'iframe', content ).get(0).contentWindow;
-
-                    if ( win && win.mejs ) {
+                    var p, win,
+                        iframe = $( 'iframe.wpview-sandbox', content ).get(0);
+
+                    if ( iframe && ( win = iframe.contentWindow ) && win.mejs ) {
                         for ( p in win.mejs.players ) {
                             win.mejs.players[p].remove();