Changeset 29251

Timestamp:

07/19/2014 11:58:07 PM (10 years ago)

Author:

wonderboymusic

Message:

Backup filter globals ( $merged_filters, $wp_actions, $wp_current_filter, $wp_filter ) statically when running unit tests, restore on tearDown(). This ensures that all tests initially use the same filters/actions.

Props mnelson4, wonderboymusic.
Fixes #28535.

File:

• trunk/tests/phpunit/includes/testcase.php (modified) (4 diffs)

trunk/tests/phpunit/includes/testcase.php

@@ -12 +12 @@
     protected $caught_doing_it_wrong = array();
 
+    protected static $hooks_saved = array();
     protected static $ignore_files;
 
@@ -24 +25 @@
         if ( ! self::$ignore_files ) {
             self::$ignore_files = $this->scan_user_uploads();
+        }
+
+        if ( ! self::$hooks_saved ) {
+            $this->_backup_hooks();
         }
 
@@ -53 +58 @@
         remove_filter( 'query', array( $this, '_drop_temporary_tables' ) );
         remove_filter( 'wp_die_handler', array( $this, 'get_wp_die_handler' ) );
+        $this->_restore_hooks();
     }
 
@@ -61 +67 @@
     }
 
+    /**
+     * Saves the action and filter-related globals so they can be restored later
+     *
+     * Stores $merged_filters, $wp_actions, $wp_current_filter, and $wp_filter
+     * on a class variable so they can be restored on tearDown() using _restore_hooks()
+     * @global array $merged_filters
+     * @global array $wp_actions
+     * @global array $wp_current_filter
+     * @global array $wp_filter
+     * @return void
+     */
+    protected function _backup_hooks() {
+        $globals = array( 'merged_filters', 'wp_actions', 'wp_current_filter', 'wp_filter' );
+        foreach ( $globals as $key ) {
+            self::$hooks_saved[ $key ] = $GLOBALS[ $key ];
+        }
+    }
+
+    /**
+     * Restores the hook-related globals to their state at setUp()
+     *
+     * so that future tests aren't affected by hooks set during this last test
+     *
+     * @global array $merged_filters
+     * @global array $wp_actions
+     * @global array $wp_current_filter
+     * @global array $wp_filter
+     * @return void
+     */
+    protected function _restore_hooks(){
+        $globals = array( 'merged_filters', 'wp_actions', 'wp_current_filter', 'wp_filter' );
+        foreach ( $globals as $key ) {
+            $GLOBALS[ $key ] = self::$hooks_saved[ $key ];
+        }
+    }
+    
     function flush_cache() {
         global $wp_object_cache;