Changeset 29263

Timestamp:

07/22/2014 02:19:21 AM (12 years ago)

Author:

helen

Message:

Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977.

Location:

trunk/src/wp-includes

Files:

• js/media-grid.js (modified) (2 diffs)
• media-template.php (modified) (2 diffs)

trunk/src/wp-includes/js/media-grid.js

@@ -286 +286 @@
                         'click .edit-attachment':         'editAttachment',
                         'click .refresh-attachment':      'refreshAttachment',
-                        'click .edit-image':              'handleEditImageClick',
-                        'click .view-attachment':         'handleViewAttachmentClick'
+                        'click .edit-image':              'handleEditImageClick'
                 },
 
@@ -328 +327 @@
                 handleEditImageClick: function() {
                         this.controller.setState( 'edit-image' );
-                },
-
-                /**
-                 * When View is clicked, navigate to the attachment page
-                 */
-                handleViewAttachmentClick: function() {
-                        window.location = this.model.get( 'link' );
                 },
 

trunk/src/wp-includes/media-template.php

@@ -298 +298 @@
                                         <# } #>
 
-                                        <a class="button view-attachment" href="#"><?php _e( 'View' ); ?></a>
-
                                         <# if ( ! data.uploading && data.can.remove ) { #>
                                                 <?php if ( MEDIA_TRASH ): ?>
@@ -394 +392 @@
                         </div>
 
+                        <a class="view-attachment" href="{{ data.link }}"><?php _e( 'View attachment page' ); ?></a> |
                         <a href="post.php?post={{ data.id }}&action=edit"><?php _e( 'Edit more details' ); ?></a>