Changeset 29285

Timestamp:

07/24/2014 08:57:05 PM (7 years ago)

Author:

wonderboymusic

Message:

Don't render Attachment Display Settings when display is set to false. Currently, the value for display in the media.view.AttachmentsBrowser instance in the media.view.MediaFrame.Select frame is set to the value for displaySettings.
These values do different things, so check for the existence of display on the state before arbitrarily setting it to the displaySettings value.

Real world: this hides display settings when you select an image while editing a Gallery.

Fixes #28653.

File:

• trunk/src/wp-includes/js/media-views.js (modified) (2 diffs)

trunk/src/wp-includes/js/media-views.js

@@ -831 +831 @@
             searchable:      false,
             sortable:        true,
+            display:         false,
             // Initial region modes.
             content:         'browse',
@@ -2175 +2176 @@
                 search:     state.get('searchable'),
                 filters:    state.get('filterable'),
-                display:    state.get('displaySettings'),
+                display:    state.has('display') ? state.get('display') : state.get('displaySettings'),
                 dragInfo:   state.get('dragInfo'),