Changeset 29294

Timestamp:

07/25/2014 12:19:21 AM (10 years ago)

Author:

wonderboymusic

Message:

Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label.

Props joedolson.
Fixes #28867.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-list-table.php (modified) (4 diffs)
• class-wp-plugins-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -344 +344 @@
      * @since 3.1.0
      * @access protected
-     */
-    protected function bulk_actions() {
+     *
+     * @param string $which The location of the bulk actions: 'top' or 'bottom'.
+     */
+    protected function bulk_actions( $which ) {
         if ( is_null( $this->_actions ) ) {
             $no_new_actions = $this->_actions = $this->get_bulk_actions();
@@ -370 +372 @@
             return;
 
-        echo "<select name='action$two'>\n";
+        echo "<label for='bulk-action-selector-" . esc_attr( $which ) . "' class='screen-reader-text'>" . __( 'Select Bulk Action' ) . "</label>";
+        echo "<select name='action$two' id='bulk-action-selector-" . esc_attr( $which ) . "'>\n";
         echo "<option value='-1' selected='selected'>" . __( 'Bulk Actions' ) . "</option>\n";
 
@@ -639 +642 @@
             $html_current_page = $current;
         } else {
-            $html_current_page = sprintf( "<input class='current-page' title='%s' type='text' name='paged' value='%s' size='%d' />",
+            $html_current_page_label = "<label for='current-page-selector'>" . __( 'Select Page' ) . "</label>";
+            $html_current_page = $html_current_page_label . sprintf( "<input class='current-page' id='current-page-selector' title='%s' type='text' name='paged' value='%s' size='%d' />",
                 esc_attr__( 'Current page' ),
                 $current,
@@ -899 +903 @@
 
         <div class="alignleft actions bulkactions">
-            <?php $this->bulk_actions(); ?>
+            <?php $this->bulk_actions( $which ); ?>
         </div>
 <?php

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -299 +299 @@
     }
 
-    public function bulk_actions() {
+    public function bulk_actions( $which ) {
         global $status;
 
@@ -305 +305 @@
             return;
 
-        parent::bulk_actions();
+        parent::bulk_actions( $which );
     }