Changeset 29331

Timestamp:

07/30/2014 05:38:18 PM (10 years ago)

Author:

helen

Message:

Prevent key event handlers from firing when in input areas in the media modal, as people understandably want to type inside said inputs. props kovshenin. fixes #28704.

File:

• trunk/src/wp-includes/js/media-views.js (modified) (3 diffs)

trunk/src/wp-includes/js/media-views.js

@@ -4753 +4753 @@
             var method;
 
+            // Don't do anything inside inputs.
+            if ( 'input' === event.target.tagName.toLowerCase() ) {
+                return
+            }
+
             // Catch arrow events
             if ( 37 === event.keyCode || 38 === event.keyCode || 39 === event.keyCode || 40 === event.keyCode ) {
@@ -4768 +4773 @@
                 // Pass the current target to restore focus when closing
                 this.controller.trigger( 'edit:attachment', this.model, event.currentTarget );
+
+                // Don't scroll the view and don't attempt to submit anything.
+                event.stopPropagation();
                 return;
             }
@@ -4780 +4788 @@
                 method: method
             });
+
+            // Don't scroll the view and don't attempt to submit anything.
+            event.stopPropagation();
         },
         /**