Make WordPress Core


Ignore:
Timestamp:
08/06/2014 10:07:42 PM (11 years ago)
Author:
wonderboymusic
Message:

After [29339] and [29341], add more unit tests and less ambiguous type-checking before bailing in meta-related functions that expect a numeric value for $object_id.

Props SergeyBiryukov.
Fixes #28315.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/meta.php

    r28659 r29421  
    237237        $this->assertEquals( wp_list_pluck( $posts, 'post_title' ), wp_list_pluck( $posts2, 'post_title' ) );
    238238    }
     239
     240    /**
     241     * @ticket 28315
     242     */
     243    function test_non_numeric_object_id() {
     244        $this->assertFalse( add_metadata( 'user', array( 1 ), 'meta_key', 'meta_value' ) );
     245        $this->assertFalse( update_metadata( 'user', array( 1 ), 'meta_key', 'meta_new_value' ) );
     246        $this->assertFalse( delete_metadata( 'user', array( 1 ), 'meta_key' ) );
     247        $this->assertFalse( get_metadata( 'user', array( 1 ) ) );
     248        $this->assertFalse( metadata_exists( 'user', array( 1 ), 'meta_key' ) );
     249    }
     250
     251    /**
     252     * @ticket 28315
     253     */
     254    function test_non_numeric_meta_id() {
     255        $this->assertFalse( get_metadata_by_mid( 'user', array( 1 ) ) );
     256        $this->assertFalse( update_metadata_by_mid( 'user', array( 1 ), 'meta_new_value' ) );
     257        $this->assertFalse( delete_metadata_by_mid( 'user', array( 1 ) ) );
     258    }
    239259}
Note: See TracChangeset for help on using the changeset viewer.