Changeset 29421 for trunk/tests/phpunit/tests/meta.php

Timestamp:

08/06/2014 10:07:42 PM (12 years ago)

Author:

wonderboymusic

Message:

After [29339] and [29341], add more unit tests and less ambiguous type-checking before bailing in meta-related functions that expect a numeric value for $object_id.

Props SergeyBiryukov.
Fixes #28315.

File:

• trunk/tests/phpunit/tests/meta.php (modified) (1 diff)

trunk/tests/phpunit/tests/meta.php

@@ -237 +237 @@
                 $this->assertEquals( wp_list_pluck( $posts, 'post_title' ), wp_list_pluck( $posts2, 'post_title' ) );
         }
+
+        /**
+         * @ticket 28315
+         */
+        function test_non_numeric_object_id() {
+                $this->assertFalse( add_metadata( 'user', array( 1 ), 'meta_key', 'meta_value' ) );
+                $this->assertFalse( update_metadata( 'user', array( 1 ), 'meta_key', 'meta_new_value' ) );
+                $this->assertFalse( delete_metadata( 'user', array( 1 ), 'meta_key' ) );
+                $this->assertFalse( get_metadata( 'user', array( 1 ) ) );
+                $this->assertFalse( metadata_exists( 'user', array( 1 ), 'meta_key' ) );
+        }
+
+        /**
+         * @ticket 28315
+         */
+        function test_non_numeric_meta_id() {
+                $this->assertFalse( get_metadata_by_mid( 'user', array( 1 ) ) );
+                $this->assertFalse( update_metadata_by_mid( 'user', array( 1 ), 'meta_new_value' ) );
+                $this->assertFalse( delete_metadata_by_mid( 'user', array( 1 ) ) );
+        }
 }