Changeset 29435

Timestamp:

08/07/2014 08:24:25 PM (10 years ago)

Author:

wonderboymusic

Message:

Media Grid: add screen reader text in a subview on the toolbar, a media.view.Label instance before media.view.DateFilter.

See #29026.

Location:

trunk/src/wp-includes

Files:

• js/media-views.js (modified) (3 diffs)
• media.php (modified) (1 diff)

trunk/src/wp-includes/js/media-views.js

@@ -5717 +5717 @@
                     template: media.template( 'media-library-view-switcher')
                 });
+
                 this.toolbar.set( 'libraryViewSwitcher', new LibraryViewSwitcher({
                     controller: this.controller,
@@ -5722 +5723 @@
                 }).render() );
 
+                // BulkSelection is a <div> with subviews, including screen reader text
                 this.toolbar.set( 'bulkSelection', new media.view.BulkSelection({
                     controller: this.controller,
                     priority: -70
+                }).render() );
+
+                // DateFilter is a <select>, screen reader text needs to be rendered before
+                this.toolbar.set( 'dateFilterLabel', new media.view.Label({
+                    value: l10n.filterByDate,
+                    attributes: {
+                        'for': 'media-attachment-date-filters'
+                    },
+                    priority: -75
                 }).render() );
                 this.toolbar.set( 'dateFilter', new media.view.DateFilter({
@@ -6584 +6595 @@
         render: function() {
             this.$el.html( this.value );
+
+            return this;
         }
     });

trunk/src/wp-includes/media.php

@@ -2941 +2941 @@
         'deletePermanently'      => __( 'Delete Permanently' ),
         'apply'                  => __( 'Apply' ),
+        'filterByDate'           => __( 'Filter by date' ),
 
         // Library Details