WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/12/2014 11:01:38 PM (6 years ago)
Author:
helen
Message:

Plugin details modal:

  • Scroll all content, rather than the dual-pane scrolling awkwardness.
  • Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
  • Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.

props stephdau, tellyworth, helen. fixes #27440.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/plugin-install.php

    r29218 r29474  
    373373
    374374    iframe_header( __( 'Plugin Install' ) );
    375 
     375   
    376376    $_with_banner = '';
    377377
     
    394394    }
    395395
     396    echo '<div id="plugin-information-scrollable">';
    396397    echo "<div id='{$_tab}-title' class='{$_with_banner}'><div class='vignette'></div><h2>{$api->name}</h2></div>";
    397398    echo "<div id='{$_tab}-tabs' class='{$_with_banner}'>\n";
     
    514515    echo "</div>\n";
    515516    echo "</div>\n";
     517    echo "</div>\n"; // #plugin-information-scrollable
    516518    echo "<div id='$tab-footer'>\n";
    517519    if ( ! empty( $api->download_link ) && ( current_user_can( 'install_plugins' ) || current_user_can( 'update_plugins' ) ) ) {
Note: See TracChangeset for help on using the changeset viewer.