Changeset 29474 for trunk/src/wp-admin/includes/plugin-install.php

Timestamp:

08/12/2014 11:01:38 PM (6 years ago)

Author:

helen

Message:

Plugin details modal:

• Scroll all content, rather than the dual-pane scrolling awkwardness.
• Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
• Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.

props stephdau, tellyworth, helen. fixes #27440.

File:

• trunk/src/wp-admin/includes/plugin-install.php (modified) (3 diffs)

trunk/src/wp-admin/includes/plugin-install.php

@@ -373 +373 @@
 
     iframe_header( __( 'Plugin Install' ) );
-
+    
     $_with_banner = '';
 
@@ -394 +394 @@
     }
 
+    echo '<div id="plugin-information-scrollable">';
     echo "<div id='{$_tab}-title' class='{$_with_banner}'><div class='vignette'></div><h2>{$api->name}</h2></div>";
     echo "<div id='{$_tab}-tabs' class='{$_with_banner}'>\n";
@@ -514 +515 @@
     echo "</div>\n";
     echo "</div>\n";
+    echo "</div>\n"; // #plugin-information-scrollable
     echo "<div id='$tab-footer'>\n";
     if ( ! empty( $api->download_link ) && ( current_user_can( 'install_plugins' ) || current_user_can( 'update_plugins' ) ) ) {