Changeset 29528

Timestamp:

08/18/2014 02:34:03 AM (10 years ago)

Author:

wonderboymusic

Message:

Media Grid: don't try to display images that don't have data.sizes set. Also, don't show the "Edit Image" button.

Props ocean90.
Fixes #29245.

File:

• trunk/src/wp-includes/media-template.php (modified) (4 diffs)

trunk/src/wp-includes/media-template.php

@@ -277 +277 @@
                 <# if ( data.uploading ) { #>
                     <div class="media-progress-bar"><div></div></div>
-                <# } else if ( 'image' === data.type ) { #>
+                <# } else if ( 'image' === data.type && data.sizes && data.sizes.full ) { #>
                     <img class="details-image" src="{{ data.sizes.full.url }}" draggable="false" />
                 <# } else if ( -1 === jQuery.inArray( data.type, [ 'audio', 'video' ] ) ) { #>
@@ -311 +311 @@
 
                 <div class="attachment-actions">
-                    <# if ( 'image' === data.type && ! data.uploading ) { #>
+                    <# if ( 'image' === data.type && ! data.uploading && data.sizes ) { #>
                         <a class="button edit-attachment" href="#"><?php _e( 'Edit Image' ); ?></a>
                     <# } #>
@@ -426 +426 @@
                 <# if ( data.uploading ) { #>
                     <div class="media-progress-bar"><div>
-                <# } else if ( 'image' === data.type ) { #>
+                <# } else if ( 'image' === data.type && data.sizes ) { #>
                     <div class="centered">
                         <img src="{{ data.size.url }}" draggable="false" alt="" />
@@ -482 +482 @@
                 <# if ( data.uploading ) { #>
                     <div class="media-progress-bar"><div></div></div>
-                <# } else if ( 'image' === data.type ) { #>
+                <# } else if ( 'image' === data.type && data.sizes ) { #>
                     <img src="{{ data.size.url }}" draggable="false" />
                 <# } else { #>