Changeset 29562

Timestamp:

08/21/2014 02:52:24 AM (11 years ago)

Author:

wonderboymusic

Message:

media.view.Attachment: set all of the view attributes in the same hash.

See [29299], #23560.

File:

• trunk/src/wp-includes/js/media-views.js (modified) (4 diffs)

trunk/src/wp-includes/js/media-views.js

@@ -4665 +4665 @@
         template:  media.template('attachment'),
 
-        attributes: {
-            tabIndex: 0,
-            role: 'checkbox'
+        attributes: function() {
+            return {
+                'tabIndex':     0,
+                'role':         'checkbox',
+                'aria-label':   this.model.get( 'title' ),
+                'aria-checked': false,
+                'data-id':      this.model.get( 'id' )
+            };
         },
 
@@ -4689 +4694 @@
                     rerenderOnModelChange: true
                 } );
-            this.$el.attr( {
-                'aria-label'  : this.model.get( 'title' ),
-                'aria-checked': false,
-                'data-id'     : this.model.get( 'id' )
-            } );
 
             if ( options.rerenderOnModelChange ) {
@@ -4955 +4955 @@
 
             // Add 'selected' class to model, set aria-checked to true and make the checkbox tabable.
-            this.$el.addClass( 'selected' ).attr( 'aria-checked', true ).find( '.check' ).attr( 'tabindex', '0' );
+            this.$el.addClass( 'selected' ).attr( 'aria-checked', true )
+                .find( '.check' ).attr( 'tabindex', '0' );
         },
         /**
@@ -4971 +4972 @@
             }
             this.$el.removeClass( 'selected' ).attr( 'aria-checked', false )
-                    .find( '.check' ).attr( 'tabindex', '-1' );
+                .find( '.check' ).attr( 'tabindex', '-1' );
         },
         /**