Changeset 29664 for trunk/tests/phpunit/tests/db.php

Timestamp:

09/02/2014 04:55:17 AM (11 years ago)

Author:

nacin

Message:

DB: Revert [28814] and require a WHERE for wpdb::update().

see #26106.

File:

• trunk/tests/phpunit/tests/db.php (modified) (2 diffs)

trunk/tests/phpunit/tests/db.php

@@ -439 +439 @@
 
     /**
+     * wpdb::update() requires a WHERE condition.
      *
      * @ticket 26106
      */
-    function test_empty_where() {
-        global $wpdb;
+    function test_empty_where_on_update() {
+        global $wpdb;
+        $show = $wpdb->show_errors(false);
         $wpdb->update( $wpdb->posts, array( 'post_name' => 'burrito' ), array() );
 
-        $expected1 = "UPDATE `{$wpdb->posts}` SET `post_name` = 'burrito'";
+        $expected1 = "UPDATE `{$wpdb->posts}` SET `post_name` = 'burrito' WHERE ";
+        $this->assertNotEmpty( $wpdb->last_error );
         $this->assertEquals( $expected1, $wpdb->last_query );
 
@@ -452 +455 @@
 
         $expected2 = "UPDATE `{$wpdb->posts}` SET `post_name` = 'burrito' WHERE `post_status` = 'taco'";
+        $this->assertEmpty( $wpdb->last_error );
         $this->assertEquals( $expected2, $wpdb->last_query );
+        $wpdb->show_errors( $show );
     }
 }