Changeset 29665

Timestamp:

09/02/2014 06:49:11 AM (10 years ago)

Author:

nacin

Message:

Unit tests for has_filter() not resetting the array pointer.

props pento.
fixes #29070. see [29472].

Location:

trunk

Files:

• src/wp-includes/plugin.php (modified) (1 diff)
• tests/phpunit/tests/filters.php (modified) (1 diff)

trunk/src/wp-includes/plugin.php

@@ -106 +106 @@
  */
 function has_filter($tag, $function_to_check = false) {
+    // Don't reset the internal array pointer
     $wp_filter = $GLOBALS['wp_filter'];
 

trunk/tests/phpunit/tests/filters.php

@@ -294 +294 @@
         $this->assertFalse( has_filter( $tag ) );
     }
+
+    /**
+     * @ticket 29070
+     */
+     function test_has_filter_doesnt_reset_wp_filter() {
+        add_action( 'action_test_has_filter_doesnt_reset_wp_filter', '__return_null', 1 );
+        add_action( 'action_test_has_filter_doesnt_reset_wp_filter', '__return_null', 2 );
+        add_action( 'action_test_has_filter_doesnt_reset_wp_filter', '__return_null', 3 );
+        add_action( 'action_test_has_filter_doesnt_reset_wp_filter', array( $this, '_action_test_has_filter_doesnt_reset_wp_filter' ), 4 );
+
+        do_action( 'action_test_has_filter_doesnt_reset_wp_filter' );
+     }
+     function _action_test_has_filter_doesnt_reset_wp_filter() {
+        global $wp_filter;
+
+        has_action( 'action_test_has_filter_doesnt_reset_wp_filter', '_function_that_doesnt_exist' );
+
+        $filters = current( $wp_filter['action_test_has_filter_doesnt_reset_wp_filter'] );
+        $the_ = current( $filters );
+        $this->assertEquals( $the_['function'], array( $this, '_action_test_has_filter_doesnt_reset_wp_filter' ) );
+     }
 }