Changeset 29671

Timestamp:

09/02/2014 09:07:08 AM (10 years ago)

Author:

SergeyBiryukov

Message:

Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances.

props nacin.
fixes #28090.

Location:

trunk/src/wp-admin

Files:

• edit-form-advanced.php (modified) (1 diff)
• includes/media.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-advanced.php

@@ -505 +505 @@
     'dfw' => true,
     'drag_drop_upload' => true,
-    'tabfocus_elements' => 'insert-media-button-1,save-post',
+    'tabfocus_elements' => 'insert-media-button,save-post',
     'editor_height' => 300,
     'tinymce' => array(

trunk/src/wp-admin/includes/media.php

@@ -529 +529 @@
     $img = '<span class="wp-media-buttons-icon"></span> ';
 
-    printf( '<a href="#" id="insert-media-button-%d" class="button insert-media add_media" data-editor="%s" title="%s">%s</a>',
-        $instance,
+    $id_attribute = $instance === 1 ? ' id="insert-media-button"' : '';
+    printf( '<a href="#"%s class="button insert-media add_media" data-editor="%s" title="%s">%s</a>',
+        $id_attribute,
         esc_attr( $editor_id ),
         esc_attr__( 'Add Media' ),