Changeset 29693

Timestamp:

09/03/2014 09:57:56 AM (12 years ago)

Author:

helen

Message:

Editor scrolling: Remember and restore scroll position for visual and text modes.

This prevents the editor from jumping off screen when the rendered visual content is significantly taller than plain text, e.g. when there are views present.

This is also a close restoration of 3.9 behavior, some of which was browser-specific.

props avryl.
fixes #29338.

File:

• trunk/src/wp-admin/js/editor-expand.js (modified) (2 diffs)

trunk/src/wp-admin/js/editor-expand.js

@@ -32 +32 @@
                 scrollTimer,
                 lastScrollPosition = 0,
+                visualEditorScrollPosition = 0,
+                textEditorScrollPosition = 0,
                 pageYOffsetAtTop = 130,
                 pinnedToolsTop = 56,
@@ -225 +227 @@
                 // Adjust when switching editor modes.
                 function mceShow() {
+                        textEditorScrollPosition = window.pageYOffset;
+
                         setTimeout( function() {
+                                var top = $contentWrap.offset().top;
+
+                                if ( window.pageYOffset > top || visualEditorScrollPosition ) {
+                                        window.scrollTo( window.pageXOffset, visualEditorScrollPosition ? visualEditorScrollPosition : top - heights.adminBarHeight );
+                                }
+
                                 editor.execCommand( 'wpAutoResize' );
                                 adjust();
                         }, 300 );
+
+                        adjust();
                 }
 
                 function mceHide() {
-                        var wrapHeight = $( '#wpwrap' ).height();
-
-                        textEditorResize();
-
-                        if ( wrapHeight && $window.scrollTop() > wrapHeight ) {
-                                window.scrollTo( window.pageXOffset, wrapHeight - 1 );
-                        }
+                        visualEditorScrollPosition = window.pageYOffset;
+
+                        setTimeout( function() {
+                                var top = $contentWrap.offset().top;
+
+                                if ( window.pageYOffset > top || textEditorScrollPosition ) {
+                                        window.scrollTo( window.pageXOffset, textEditorScrollPosition ? textEditorScrollPosition : top - heights.adminBarHeight );
+                                }
+
+                                textEditorResize();
+                                adjust();
+                        }, 100 );
 
                         adjust();