Changeset 29694

Timestamp:

09/03/2014 10:37:21 AM (12 years ago)

Author:

ocean90

Message:

Language Pack Upgrader: Allow to disable asynchronously translation updates.

• Don't touch VCS installs.
• Use the async_update_translation filter (which corresponds exactly to auto_update_translation) to entirely disable it, or based on the update offer.

props nacin, ocean90.
fixes #28571.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-upgrader.php

@@ -1197 +1197 @@
         public static function async_upgrade( $upgrader = false ) {
                 // Avoid recursion.
-                if ( $upgrader && $upgrader instanceof Language_Pack_Upgrader )
+                if ( $upgrader && $upgrader instanceof Language_Pack_Upgrader ) {
                         return;
+                }
 
                 // Nothing to do?
                 $language_updates = wp_get_translation_updates();
-                if ( ! $language_updates )
+                if ( ! $language_updates ) {
                         return;
+                }
+
+                // Avoid messing with VCS installs, at least for now.
+                // Noted: this is not the ideal way to accomplish this.
+                $check_vcs = new WP_Automatic_Updater;
+                if ( $check_vcs->is_vcs_checkout( WP_CONTENT_DIR ) ) {
+                        return;
+                }
+
+                foreach ( $language_updates as $key => $language_update ) {
+                        $update = ! empty( $language_update->autoupdate );
+
+                        /**
+                         * Filter whether to asynchronously update translation for core, a plugin, or a theme.
+                         *
+                         * @since 4.0.0
+                         *
+                         * @param bool   $update          Whether to update.
+                         * @param object $language_update The update offer.
+                         */
+                        $update = apply_filters( 'async_update_translation', $update, $language_update );
+
+                        if ( ! $update ) {
+                                unset( $language_updates[ $key ] );
+                        }
+                }
+
+                if ( empty( $language_updates ) ) {
+                        return;
+                }
 
                 $skin = new Language_Pack_Upgrader_Skin( array(
@@ -1210 +1241 @@
 
                 $lp_upgrader = new Language_Pack_Upgrader( $skin );
-                $lp_upgrader->upgrade();
+                $lp_upgrader->bulk_upgrade( $language_updates );
         }