Changeset 29737

Timestamp:

09/11/2014 08:14:56 PM (10 years ago)

Author:

wonderboymusic

Message:

In media_handle_upload(), don't call wp_read_image_metadata() on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling @wp_read_image_metadata().

Props jrf for the initial patch.
Fixes #28907.

File:

• trunk/src/wp-admin/includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -320 +320 @@
 
     // Use image exif/iptc data for title and caption defaults if possible.
-    } elseif ( $image_meta = @wp_read_image_metadata( $file ) ) {
+    } elseif ( 0 === strpos( $type, 'image/' ) && $image_meta = @wp_read_image_metadata( $file ) ) {
         if ( trim( $image_meta['title'] ) && ! is_numeric( sanitize_title( $image_meta['title'] ) ) )
             $title = $image_meta['title'];