Changeset 29781 for trunk/tests/phpunit/tests/formatting/WPTexturize.php

Timestamp:

09/29/2014 04:06:54 AM (10 years ago)

Author:

wonderboymusic

Message:

The joys of wptexturize():

• Revert parts of [28773] and [28727] and [29748].
• Do not crash PHP. Make the shortcode quantifier possessive to avoid backtracks.
• Reduce backtracking in long HTML comments by 100x.
• Do not ignore unclosed HTML comments.
• Do not break unregistered shortcodes, e.g. [hello attr="value"].
• Do not break HTML in shortcode attributes, e.g. [hello attr="<"].
• Do not match for shortcodes when there is extra whitespace, e.g. [ hello ].
• Add unit tests to show #12690 was not fully resolved.
• Tested PHP 5.2.4, 5.2.13, 5.4.32, and 5.5.8.

Adds/modifies unit tests.

Props miqrogroove.
See #29557.

File:

• trunk/tests/phpunit/tests/formatting/WPTexturize.php (modified) (5 diffs)

trunk/tests/phpunit/tests/formatting/WPTexturize.php

@@ -1189 +1189 @@
         return array(
             array(
+                '[ ... ]',
+                '[ … ]',
+            ),
+            array(
                 '[ is it wise to <a title="allow user content ] here? hmm"> maybe </a> ]',
                 '[ is it wise to <a title="allow user content ] here? hmm"> maybe </a> ]',
             ),
             array(
+                '[is it wise to <a title="allow user content ] here? hmm"> maybe </a> ]', // HTML corruption is a known bug.  See tickets #12690 and #29557.
+                '[is it wise to <a title="allow user content ] here? hmm&#8221;> maybe </a> ]',
+            ),
+            array(
+                '[caption - is it wise to <a title="allow user content ] here? hmm"> maybe </a> ]',
+                '[caption - is it wise to <a title="allow user content ] here? hmm&#8221;> maybe </a> ]',
+            ),
+            array(
                 '[ photos by <a href="http://example.com/?a[]=1&a[]=2"> this guy </a> ]',
                 '[ photos by <a href="http://example.com/?a[]=1&#038;a[]=2"> this guy </a> ]',
             ),
             array(
+                '[photos by <a href="http://example.com/?a[]=1&a[]=2"> this guy </a>]',
+                '[photos by <a href="http://example.com/?a[]=1&#038;a[]=2"> this guy </a>]',
+            ),
+            array(
                 '[gallery ...]',
                 '[gallery ...]',
@@ -1213 +1229 @@
             ),
             array(
-                '[...]...[/...]', // These are potentially usable shortcodes.
-                '[&#8230;]&#8230;[/&#8230;]',
-            ),
-            array(
                 '[[gallery]]...[[/gallery]]', // Shortcode parsing will ignore the inner ]...[ part and treat this as a single escaped shortcode.
                 '[[gallery]]&#8230;[[/gallery]]',
@@ -1225 +1237 @@
             ),
             array(
-                '[gal>ery ...]',
-                '[gal>ery &#8230;]',
-            ),
-            array(
                 '[gallery ...',
                 '[gallery &#8230;',
@@ -1301 +1309 @@
             ),
             array(
-                '<!-- ... -- >',
-                '<!-- ... -- >',
+                '<!-- ... -- > ...',
+                '<!-- ... -- > ...',
+            ),
+            array(
+                '<!-- ...', // An unclosed comment is still a comment.
+                '<!-- ...',
+            ),
+            array(
+                'a<!-->b', // Browsers seem to allow this.
+                'a<!-->b',
+            ),
+            array(
+                'a<!--->b',
+                'a<!--->b',
+            ),
+            array(
+                'a<!---->b',
+                'a<!---->b',
+            ),
+            array(
+                'a<!----->b',
+                'a<!----->b',
+            ),
+            array(
+                'a<!-- c --->b',
+                'a<!-- c --->b',
+            ),
+            array(
+                'a<!-- c -- d -->b',
+                'a<!-- c -- d -->b',
+            ),
+            array(
+                'a<!-- <!-- c --> -->b<!-- close -->',
+                'a<!-- <!-- c --> &#8211;>b<!-- close -->',
             ),
             array(
@@ -1728 +1768 @@
             array(
                 '[code ...]...[/code]', // code is not a registered shortcode.
-                '[code &#8230;]&#8230;[/code]',
+                '[code ...]...[/code]',
             ),
             array(
                 '[hello ...]...[/hello]', // hello is not a registered shortcode.
-                '[hello &#8230;]&#8230;[/hello]',
+                '[hello ...]&#8230;[/hello]',
+            ),
+            array(
+                '[...]...[/...]', // These are potentially usable shortcodes.
+                '[...]&#8230;[/...]',
+            ),
+            array(
+                '[gal>ery ...]',
+                '[gal>ery ...]',
+            ),
+            array(
+                '[randomthing param="test"]',
+                '[randomthing param="test"]',
             ),
             array(