Changeset 29818

Timestamp:

10/02/2014 03:55:51 PM (10 years ago)

Author:

wonderboymusic

Message:

In activate_plugin(), do not re-run the activation routine for already-active network-wide plugins.

Adds unit test.

Props jbrinley.
Fixes #28651.

Location:

trunk

Files:

• src/wp-admin/includes/plugin.php (modified) (1 diff)
• tests/phpunit/tests/ms.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -534 +534 @@
         return $valid;
 
-    if ( !in_array($plugin, $current) ) {
+    if ( ( $network_wide && ! isset( $current[ $plugin ] ) ) || ( ! $network_wide && ! in_array( $plugin, $current ) ) ) {
         if ( !empty($redirect) )
             wp_redirect(add_query_arg('_error_nonce', wp_create_nonce('plugin-activation-error_' . $plugin), $redirect)); // we'll override this later if the plugin can be included without fatal error

trunk/tests/phpunit/tests/ms.php

@@ -302 +302 @@
     }
 
+    /**
+     * @ticket 28651
+     */
+    function test_duplicate_network_active_plugin() {
+        $path = "hello.php";
+        $mock = new MockAction();
+        add_action( 'activate_' . $path, array ( $mock, 'action' ) );
+
+        // should activate on the first try
+        activate_plugin( $path, '', true );
+        $active_plugins = wp_get_active_network_plugins();
+        $this->assertCount( 1, $active_plugins );
+        $this->assertEquals( 1, $mock->get_call_count() );
+
+        // should do nothing on the second try
+        activate_plugin( $path, '', true );
+        $active_plugins = wp_get_active_network_plugins();
+        $this->assertCount( 1, $active_plugins );
+        $this->assertEquals( 1, $mock->get_call_count() );
+
+        remove_action( 'activate_' . $path, array ( $mock, 'action' ) );
+    }
+
     function _helper_deactivate_hook() {
         $this->plugin_hook_count++;