Changeset 29834 for trunk/src/wp-includes/class-wp-image-editor.php

Timestamp:

10/04/2014 01:11:38 PM (11 years ago)

Author:

SergeyBiryukov

Message:

Fix setting default quality in WP_Image_Editor.

props markoheijnen.
fixes #29856 for trunk.

File:

• trunk/src/wp-includes/class-wp-image-editor.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-image-editor.php

@@ -237 +237 @@
                  */
                 $quality = apply_filters( 'jpeg_quality', $quality, 'image_resize' );
-
-                if ( ! $this->set_quality( $quality ) ) {
-                    $this->quality = $this->default_quality;
-                }
+            }
+
+            if ( ! $this->set_quality( $quality ) ) {
+                $this->quality = $this->default_quality;
             }
         }
@@ -257 +257 @@
      */
     public function set_quality( $quality = null ) {
+        if ( null === $quality ) {
+            $quality = $this->default_quality;
+        }
+
         // Allow 0, but squash to 1 due to identical images in GD, and for backwards compatibility.
-        if ( $quality == 0 ) {
+        if ( 0 === $quality ) {
             $quality = 1;
         }