Changeset 29856 for trunk/src/wp-admin/network/themes.php

Timestamp:

10/08/2014 07:04:05 PM (9 years ago)

Author:

ocean90

Message:

Language packs: Remove translations when deleting a theme or a plugin.

This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change wp_get_installed_translations() to only return a translation if the .mo file also exists.

fixes #29860.

File:

• trunk/src/wp-admin/network/themes.php (modified) (5 diffs)

trunk/src/wp-admin/network/themes.php

@@ -97 +97 @@
             exit;
         case 'delete-selected':
-            if ( ! current_user_can( 'delete_themes' ) )
+            if ( ! current_user_can( 'delete_themes' ) ) {
                 wp_die( __('You do not have sufficient permissions to delete themes for this site.') );
+            }
+
             check_admin_referer( 'bulk-themes' );
 
@@ -116 +118 @@
 
             $files_to_delete = $theme_info = array();
+            $theme_translations = wp_get_installed_translations( 'themes' );
             foreach ( $themes as $key => $theme ) {
                 $theme_info[ $theme ] = wp_get_theme( $theme );
-                $files_to_delete = array_merge( $files_to_delete, list_files( $theme_info[ $theme ]->get_stylesheet_directory() ) );
+
+                // Locate all the files in that folder.
+                $files = list_files( $theme_info[ $theme ]->get_stylesheet_directory() );
+                if ( $files ) {
+                    $files_to_delete = array_merge( $files_to_delete, $files );
+                }
+
+                // Add translation files.
+                $theme_slug = $theme_info[ $theme ]->get_stylesheet();
+                if ( ! empty( $theme_translations[ $theme_slug ] ) ) {
+                    $translations = $theme_translations[ $theme_slug ];
+
+                    foreach ( $translations as $translation => $data ) {
+                        $files_to_delete[] = $theme_slug . '-' . $translation . '.po';
+                        $files_to_delete[] = $theme_slug . '-' . $translation . '.mo';
+                    }
+                }
             }
 
@@ -137 +156 @@
                 <p><?php echo _n( 'You are about to remove the following theme:', 'You are about to remove the following themes:', $themes_to_delete ); ?></p>
                     <ul class="ul-disc">
-                        <?php foreach ( $theme_info as $theme )
-                            echo '<li>', sprintf( __('<strong>%1$s</strong> by <em>%2$s</em>' ), $theme->display('Name'), $theme->display('Author') ), '</li>'; /* translators: 1: theme name, 2: theme author */ ?>
+                    <?php
+                        foreach ( $theme_info as $theme ) {
+                            /* translators: 1: theme name, 2: theme author */
+                            echo '<li>', sprintf( __('<strong>%1$s</strong> by <em>%2$s</em>' ), $theme->display('Name'), $theme->display('Author') ), '</li>';
+                        }
+                    ?>
                     </ul>
                 <p><?php _e('Are you sure you wish to delete these themes?'); ?></p>
@@ -145 +168 @@
                     <input type="hidden" name="action" value="delete-selected" />
                     <?php
-                        foreach ( (array) $themes as $theme )
+                        foreach ( (array) $themes as $theme ) {
                             echo '<input type="hidden" name="checked[]" value="' . esc_attr($theme) . '" />';
+                        }
                     ?>
                     <?php wp_nonce_field('bulk-themes') ?>
@@ -159 +183 @@
                     <ul class="code">
                     <?php
-                        foreach ( (array) $files_to_delete as $file )
-                            echo '<li>' . esc_html( str_replace( WP_CONTENT_DIR . "/themes", '', $file) ) . '</li>';
+                        foreach ( (array) $files_to_delete as $file ) {
+                            echo '<li>' . esc_html( str_replace( WP_CONTENT_DIR . '/themes', '', $file ) ) . '</li>';
+                        }
                     ?>
                     </ul>