Changeset 29864 for trunk/src/wp-includes/class-http.php

Timestamp:

10/09/2014 03:00:16 AM (10 years ago)

Author:

dd32

Message:

Add some unit tests for WP_HTTP::parse_url() to cover the <PHP 5.4.7 compatibility alterations.

These unit tests cover the expected vehaviour of certain combinations of URL's, but makes no attempt to test invalid URL structures, as PHP's behavious for invalid URL's is undefined (Some will be treated as paths, others fail, and it varies between PHP 5.4.7+ and <5.4.7).
This change also makes WP_HTTP::parse_url() protected in order to allow unit testing.
See #28001, #29886

File:

• trunk/src/wp-includes/class-http.php (modified) (1 diff)

trunk/src/wp-includes/class-http.php

@@ -683 +683 @@
      * @since 4.1.0
      *
-     * @access private
+     * @access protected
      * @param  string $url The URL to parse
      * @return bool|array False on failure; Array of URL components on success; See parse_url()'s return values.
      */
-    private static function parse_url( $url ) {
+    protected static function parse_url( $url ) {
         $parts = @parse_url( $url );
         if ( ! $parts ) {