Changeset 29865 for trunk/tests/phpunit/tests/term.php

Timestamp:

10/09/2014 03:15:50 AM (11 years ago)

Author:

boonebgorges

Message:

Don't bail out of term_exists() when term sanitizes to an empty string.

This change brings return values for failures of this sort in line with other
failed lookups in term_exists(): a null value is now returned in all cases
where the queried term is not found.

Adds unit test for the sanitization issue. Modifies existing unit test to
reflect the change in return value for empty term strings.

Props boonebgorges, georgestephanis.
Fixes #29589.

File:

• trunk/tests/phpunit/tests/term.php (modified) (1 diff)

trunk/tests/phpunit/tests/term.php

@@ -113 +113 @@
 
     public function test_term_exists_term_trimmed_to_empty_string() {
-        $this->assertSame( 0, term_exists( '   ' ) );
+        $this->assertNull( term_exists( '   ' ) );
+    }
+
+    /**
+     * @ticket 29589
+     */
+    public function test_term_exists_existing_term_that_sanitizes_to_empty() {
+        wp_insert_term( '//', 'category' );
+        $this->assertNotEmpty( term_exists( '//' ) );
+        $this->assertNotEmpty( term_exists( '//', 'category' ) );
+
+        wp_insert_term( '>>', 'category' );
+        $this->assertNotEmpty( term_exists( '>>' ) );
+        $this->assertNotEmpty( term_exists( '>>', 'category' ) );
     }