Changeset 29867

Timestamp:

10/09/2014 06:11:17 PM (10 years ago)

Author:

boonebgorges

Message:

Return an error when adding a term to a non-existent parent.

Parallels the logic of wp_insert_term(), introduced in [29196].

Props jesin.
Fixes #29614.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/term.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -2934 +2934 @@
         return new WP_Error('empty_term_name', __('A name is required for this term'));
 
+    if ( $parsed_args['parent'] > 0 && ! term_exists( (int) $parsed_args['parent'] ) ) {
+        return new WP_Error( 'missing_parent', __( 'Parent term does not exist.' ) );
+    }
+
     $empty_slug = false;
     if ( empty( $args['slug'] ) ) {

trunk/tests/phpunit/tests/term.php

@@ -632 +632 @@
     }
 
+    /**
+     * @ticket 29614
+     */
+    function test_wp_update_term_parent_does_not_exist() {
+        register_taxonomy( 'wptests_tax', array(
+            'hierarchical' => true,
+        ) );
+        $fake_term_id = 787878;
+
+        $this->assertNull( term_exists( $fake_term_id, 'wptests_tax' ) );
+
+        $t = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+        ) );
+
+        $found = wp_update_term( $t, 'wptests_tax', array(
+            'parent' => $fake_term_id,
+        ) );
+
+        $this->assertWPError( $found );
+        $this->assertSame( 'missing_parent', $found->get_error_code() );
+
+        $term = get_term( $t, 'wptests_tax' );
+        $this->assertEquals( 0, $term->parent );
+    }
+
     public function test_wp_update_term_alias_of_no_term_group() {
         register_taxonomy( 'wptests_tax', 'post' );