Changeset 29869 for trunk/tests/phpunit/includes/testcase.php

Timestamp:

10/10/2014 08:25:39 PM (10 years ago)

Author:

boonebgorges

Message:

Only reset taxonomies and post types between tests when running core tests.

A growing number of plugins and other WP-based projects use the core test
tools, such as WP_UnitTestCase, as the basis of their own tests and continuous
integration setups. At the same time, many of these third-party plugins use
custom post types and taxonomies, which are generally registered a single time
during a run of the tests: at 'init', before the testcases have run. Wiping out
these globals between tests will mess with these third-party builds.

Best practice for plugin developers is probably to clean up their own post types
and taxonomies and then reinitialize before each test. But, in the interest of
not breaking everyone's builds, the core test suite will not enforce this.

Fixes #29827.

File:

• trunk/tests/phpunit/includes/testcase.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase.php

@@ -38 +38 @@
         $this->factory = new WP_UnitTest_Factory;
         $this->clean_up_global_scope();
-        $this->reset_post_types();
-        $this->reset_taxonomies();
+
+        /*
+         * When running core tests, ensure that post types and taxonomies
+         * are reset for each test. We skip this step for non-core tests,
+         * given the large number of plugins that register post types and
+         * taxonomies at 'init'.
+         */
+        if ( defined( 'WP_RUN_CORE_TESTS' ) && WP_RUN_CORE_TESTS ) {
+            $this->reset_post_types();
+            $this->reset_taxonomies();
+        }
+
         $this->start_transaction();
         $this->expectDeprecated();