Changeset 29878

Timestamp:

10/12/2014 12:46:26 AM (12 years ago)

Author:

azaozz

Message:

Quicktags: remove accesskey attributes the buttons and don't add empty title attributes, fixes #29358

File:

• trunk/src/wp-includes/js/quicktags.js (modified) (5 diffs)

trunk/src/wp-includes/js/quicktags.js

@@ -321 +321 @@
          * @param string|function arg1 Required. Either a starting tag to be inserted like "<span>" or a callback that is executed when the button is clicked.
          * @param string arg2 Optional. Ending tag like "</span>"
-         * @param string access_key Optional. Access key for the button.
+         * @param string access_key Deprecated Not used
          * @param string title Optional. Button's title="..."
          * @param int priority Optional. Number representing the desired position of the button in the toolbar. 1 - 9 = first, 11 - 19 = second, 21 - 29 = third, etc.
@@ -401 +401 @@
                 t.id = id;
                 t.display = display;
-                t.access = access;
+                t.access = '';
                 t.title = title || '';
                 t.instance = instance || '';
         };
         qt.Button.prototype.html = function(idPrefix) {
-                var access = this.access ? ' accesskey="' + this.access + '"' : '';
+                var title = this.title ? ' title="' + this.title + '"' : '';
+
                 if ( this.id === 'fullscreen' ) {
-                        return '<button type="button" id="' + idPrefix + this.id + '"' + access + ' class="ed_button qt-fullscreen" title="' + this.title + '"></button>';
-                }
-                return '<input type="button" id="' + idPrefix + this.id + '"' + access + ' class="ed_button button button-small" title="' + this.title + '" value="' + this.display + '" />';
+                        return '<button type="button" id="' + idPrefix + this.id + '" class="ed_button qt-fullscreen"' + title + '></button>';
+                }
+                return '<input type="button" id="' + idPrefix + this.id + '" class="ed_button button button-small"' + title + ' value="' + this.display + '" />';
         };
         qt.Button.prototype.callback = function(){};
@@ -564 +565 @@
         // the link button
         qt.LinkButton = function() {
-                qt.TagButton.call(this, 'link', 'link', '', '</a>', 'a');
+                qt.TagButton.call(this, 'link', 'link', '', '</a>');
         };
         qt.LinkButton.prototype = new qt.TagButton();
@@ -592 +593 @@
         // the img button
         qt.ImgButton = function() {
-                qt.TagButton.call(this, 'img', 'img', '', '', 'm');
+                qt.TagButton.call(this, 'img', 'img', '', '');
         };
         qt.ImgButton.prototype = new qt.TagButton();
@@ -636 +637 @@
 
         // ensure backward compatibility
-        edButtons[10] = new qt.TagButton('strong','b','<strong>','</strong>','b');
-        edButtons[20] = new qt.TagButton('em','i','<em>','</em>','i'),
+        edButtons[10] = new qt.TagButton('strong','b','<strong>','</strong>');
+        edButtons[20] = new qt.TagButton('em','i','<em>','</em>'),
         edButtons[30] = new qt.LinkButton(), // special case
-        edButtons[40] = new qt.TagButton('block','b-quote','\n\n<blockquote>','</blockquote>\n\n','q'),
-        edButtons[50] = new qt.TagButton('del','del','<del datetime="' + _datetime + '">','</del>','d'),
-        edButtons[60] = new qt.TagButton('ins','ins','<ins datetime="' + _datetime + '">','</ins>','s'),
+        edButtons[40] = new qt.TagButton('block','b-quote','\n\n<blockquote>','</blockquote>\n\n'),
+        edButtons[50] = new qt.TagButton('del','del','<del datetime="' + _datetime + '">','</del>'),
+        edButtons[60] = new qt.TagButton('ins','ins','<ins datetime="' + _datetime + '">','</ins>'),
         edButtons[70] = new qt.ImgButton(), // special case
-        edButtons[80] = new qt.TagButton('ul','ul','<ul>\n','</ul>\n\n','u'),
-        edButtons[90] = new qt.TagButton('ol','ol','<ol>\n','</ol>\n\n','o'),
-        edButtons[100] = new qt.TagButton('li','li','\t<li>','</li>\n','l'),
-        edButtons[110] = new qt.TagButton('code','code','<code>','</code>','c'),
-        edButtons[120] = new qt.TagButton('more','more','<!--more-->\n\n','','t'),
+        edButtons[80] = new qt.TagButton('ul','ul','<ul>\n','</ul>\n\n'),
+        edButtons[90] = new qt.TagButton('ol','ol','<ol>\n','</ol>\n\n'),
+        edButtons[100] = new qt.TagButton('li','li','\t<li>','</li>\n'),
+        edButtons[110] = new qt.TagButton('code','code','<code>','</code>'),
+        edButtons[120] = new qt.TagButton('more','more','<!--more-->\n\n',''),
         edButtons[140] = new qt.CloseButton();