Changeset 29890

Timestamp:

10/14/2014 02:16:28 AM (10 years ago)

Author:

boonebgorges

Message:

Use only LEFT JOINs when a meta_query contains a NOT EXISTS clause.

Mixing LEFT and INNER JOIN in these cases results in posts with no metadata
being improperly excluded from results.

Props johnrom.
Fixes #29062.

Location:

trunk

Files:

• src/wp-includes/meta.php (modified) (1 diff)
• tests/phpunit/tests/post/query.php (modified) (1 diff)

trunk/src/wp-includes/meta.php

@@ -1123 +1123 @@
 
         $sql = $this->get_sql_clauses();
+
+        /*
+         * If any JOINs are LEFT JOINs (as in the case of NOT EXISTS), then all JOINs should
+         * be LEFT. Otherwise posts with no metadata will be excluded from results.
+         */
+        if ( false !== strpos( $sql['join'], 'LEFT JOIN' ) ) {
+            $sql['join'] = str_replace( 'INNER JOIN', 'LEFT JOIN', $sql['join'] );
+        }
 
         /**

trunk/tests/phpunit/tests/post/query.php

@@ -612 +612 @@
 
     /**
+     * @ticket 29062
+     */
+    public function test_meta_query_compare_not_exists_with_another_condition_relation_or() {
+        $posts = $this->factory->post->create_many( 4 );
+        update_post_meta( $posts[0], 'color', 'orange' );
+        update_post_meta( $posts[1], 'color', 'blue' );
+        update_post_meta( $posts[1], 'vegetable', 'onion' );
+        update_post_meta( $posts[2], 'vegetable', 'shallot' );
+
+        $post_3_meta = get_post_meta( $posts[3] );
+        foreach ( $post_3_meta as $meta_key => $meta_value ) {
+            delete_post_meta( $posts[3], $meta_key );
+        }
+
+        $query = new WP_Query( array(
+            'meta_query' => array(
+                'relation' => 'OR',
+                array(
+                    'key' => 'vegetable',
+                    'value' => 'onion',
+                ),
+                array(
+                    'key' => 'color',
+                    'compare' => 'NOT EXISTS',
+                ),
+            ),
+            'update_post_meta_cache' => false,
+            'update_post_term_cache' => false,
+            'fields' => 'ids',
+        ) );
+
+        $expected = array( $posts[1], $posts[2], $posts[3] );
+        $this->assertEqualSets( $expected, $query->posts );
+    }
+
+    /**
      * @ticket 23033
      * @group meta