Changeset 29902 for trunk/tests/phpunit/tests/post/query.php

Timestamp:

10/15/2014 04:39:19 PM (12 years ago)

Author:

boonebgorges

Message:

Avoid redundant table joins in WP_Tax_Query.

IN clauses that are connected by OR require only a single table join. To avoid
extraneous joins, keep track of generated table aliases, and let sibling
clauses piggy-back on those aliases when possible.

Introduces WP_Tax_Query::sanitize_relation() to reduce some repeated code.

Adds unit tests to verify the JOIN consolidation, and integration tests for
cases where JOINS are being combined.

Props boonebgorges, otto42, jakub.tyrcha.
Fixes #18105.

File:

• trunk/tests/phpunit/tests/post/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/query.php

@@ -1377 +1377 @@
         /**
          * @group taxonomy
+         * @ticket 18105
+         */
+        public function test_tax_query_single_query_multiple_queries_operator_not_in() {
+                $t1 = $this->factory->term->create( array(
+                        'taxonomy' => 'category',
+                        'slug' => 'foo',
+                        'name' => 'Foo',
+                ) );
+                $t2 = $this->factory->term->create( array(
+                        'taxonomy' => 'category',
+                        'slug' => 'bar',
+                        'name' => 'Bar',
+                ) );
+                $p1 = $this->factory->post->create();
+                $p2 = $this->factory->post->create();
+                $p3 = $this->factory->post->create();
+
+                wp_set_post_terms( $p1, $t1, 'category' );
+                wp_set_post_terms( $p2, $t2, 'category' );
+
+                $q = new WP_Query( array(
+                        'fields' => 'ids',
+                        'update_post_meta_cache' => false,
+                        'update_post_term_cache' => false,
+                        'tax_query' => array(
+                                'relation' => 'AND',
+                                array(
+                                        'taxonomy' => 'category',
+                                        'terms' => array( 'foo' ),
+                                        'field' => 'slug',
+                                        'operator' => 'NOT IN',
+                                ),
+                                array(
+                                        'taxonomy' => 'category',
+                                        'terms' => array( 'bar' ),
+                                        'field' => 'slug',
+                                        'operator' => 'NOT IN',
+                                ),
+                        ),
+                ) );
+
+                $this->assertEquals( array( $p3 ), $q->posts );
+        }
+
+        /**
+         * @group taxonomy
          */
         public function test_tax_query_single_query_multiple_terms_operator_and() {