Changeset 29912

Timestamp:

10/16/2014 03:31:27 AM (10 years ago)

Author:

boonebgorges

Message:

Check that search value is scalar before parsing.

Prevents PHP notices when non-scalar values are passed.

Includes unit tests.

Props tivnet.
Fixes #29736.

Location:

trunk

Files:

• src/wp-includes/query.php (modified) (1 diff)
• tests/phpunit/tests/query/parseQuery.php (added)

trunk/src/wp-includes/query.php

@@ -1575 +1575 @@
 
         // Fairly insane upper bound for search string lengths.
-        if ( ! empty( $qv['s'] ) && strlen( $qv['s'] ) > 1600 )
+        if ( ! is_scalar( $qv['s'] ) || ( ! empty( $qv['s'] ) && strlen( $qv['s'] ) > 1600 ) ) {
             $qv['s'] = '';
+        }
 
         // Compat. Map subpost to attachment.