Changeset 29945

Timestamp:

10/17/2014 08:58:48 PM (10 years ago)

Author:

boonebgorges

Message:

Invalidate cache for child terms when parent term is deleted.

Props socki03.
Fixes #29911.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (2 diffs)
• tests/phpunit/tests/term.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -2415 +2415 @@
         $parent = $term_obj->parent;
 
-        $edit_tt_ids = $wpdb->get_col( "SELECT `term_taxonomy_id` FROM $wpdb->term_taxonomy WHERE `parent` = " . (int)$term_obj->term_id );
+        $edit_ids = $wpdb->get_results( "SELECT term_id, term_taxonomy_id FROM $wpdb->term_taxonomy WHERE `parent` = " . (int)$term_obj->term_id );
+        $edit_tt_ids = wp_list_pluck( $edit_ids, 'term_taxonomy_id' );
 
         /**
@@ -2426 +2427 @@
         do_action( 'edit_term_taxonomies', $edit_tt_ids );
         $wpdb->update( $wpdb->term_taxonomy, compact( 'parent' ), array( 'parent' => $term_obj->term_id) + compact( 'taxonomy' ) );
+
+        // Clean the cache for all child terms.
+        $edit_term_ids = wp_list_pluck( $edit_ids, 'term_id' );
+        clean_term_cache( $edit_term_ids, $taxonomy );
 
         /**

trunk/tests/phpunit/tests/term.php

@@ -1008 +1008 @@
 
     /**
+     * @ticket 29911
+     */
+    public function test_wp_delete_term_should_invalidate_cache_for_child_terms() {
+        register_taxonomy( 'wptests_tax', 'post', array(
+            'hierarchical' => true,
+        ) );
+
+        $parent = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+        ) );
+
+        $child = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+            'parent' => $parent,
+            'slug' => 'foo',
+        ) );
+
+        // Prime the cache.
+        $child_term = get_term( $child, 'wptests_tax' );
+        $this->assertSame( $parent, $child_term->parent );
+
+        wp_delete_term( $parent, 'wptests_tax' );
+        $child_term = get_term( $child, 'wptests_tax' );
+        $this->assertSame( 0, $child_term->parent );
+    }
+
+    /**
      * @ticket 5381
      */